Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation of ellipse bounding boxes for feature vectors #129

Open
mzur opened this issue Oct 12, 2023 · 1 comment
Open

Fix implementation of ellipse bounding boxes for feature vectors #129

mzur opened this issue Oct 12, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mzur
Copy link
Member

mzur commented Oct 12, 2023

The bounding box of ellipses used to generate feature vectors is currently not generated correctly (here). Here is how ellipses are represented in BIIGLE:

ellipse

The bounding box (red) will not cover the entire ellipse.

Thinking about it, maybe this is an issue with rectangles, too. Check how rectangles are stored (the four points are the corners or the middle of the lines, like the ellipse). Rectangles are fine.

References #128

@mzur mzur added the bug Something isn't working label Oct 12, 2023
@mzur mzur mentioned this issue Oct 12, 2023
8 tasks
@mzur mzur moved this to Medium Priority in BIIGLE Roadmap Oct 12, 2023
@mzur
Copy link
Member Author

mzur commented Oct 12, 2023

Last time we checked, ellipses were almost never used. Maybe we can even live with this compromise. What is the worst case of a mismatching bounding box here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Medium Priority
Development

No branches or pull requests

1 participant