Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assist with core.async debugging #3

Closed
darwin opened this issue Jan 28, 2016 · 1 comment
Closed

Assist with core.async debugging #3

darwin opened this issue Jan 28, 2016 · 1 comment
Labels
enhancement

Comments

@darwin
Copy link
Member

darwin commented Jan 28, 2016

I can imagine implementing "core.async" sidebar pane on Sources panel.

When stopped on a breakpoint this pane would list all existing go blocks and their state (running/how they are parked). One could click on them to see the source code location where given go block is being parked.

Another feature could be better presentation of channels. Custom formatter could display all pending puts and takes on given channel, also it could display state of associated buffer.

This would require a fork of core.async with added debugging capabilities.
babot pushed a commit that referenced this issue Feb 2, 2016
@alexkozy
Revert of Change Event.deepPath to a method (patchset #3 id:40001 of h…
a652569 
…ttps://codereview.chromium.org/1637813002/ )

Reason for revert:
This breaks new DevTools frontend while remote debugging old backends.

Original issue's description:
> Change Event.deepPath to a method
>
> In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
> See the discussion here: WICG/webcomponents#361
> Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
> See the spec change here: WICG/webcomponents@ed93413
> BUG=531990
>
> Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
> Cr-Commit-Position: refs/heads/master@{#372596}

[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=531990

Review URL: https://codereview.chromium.org/1651193003

Cr-Commit-Position: refs/heads/master@{#372713}
babot pushed a commit that referenced this issue Feb 8, 2016
@nico
Revert of DevTools: do not use platform/ to load injected scripts int…
5f3b8e4 
…o inspector/v8. (patchset #3 id:100001 of https://codereview.chromium.org/1670813003/ )

Reason for revert:
broke https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/14241/steps/generate_build_files/logs/stdio :

GYP_DEFINES='branding=Chrome buildtype=Official use_goma=1 gomadir=/b/build/goma chromeos=1'
python build/gyp_chromium -G output_dir=out
  -> returned 1
Updating projects from gyp files...
Traceback (most recent call last):
  File "tools/jsbundler.py", line 48, in <module>
    import rjsmin
ImportError: No module named rjsmin
gyp: Call to 'python tools/jsbundler.py -r . -r . -r ../../../../../chrome/third_party/chromevox/third_party/closure-library/closure/goog -x testing -x _test.js chromevox/injected/loader.js' returned exit status 1 while in /b/build/slave/google-chrome-rel-chromeos/build/src/chrome/browser/resources/chromeos/chromevox/chromevox.gyp.
step returned non-zero exit code: 1

(also on https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20(dbg) )

Original issue's description:
> DevTools: do not use platform/ to load injected scripts into inspector/v8.
>
> BUG=580337
> TBR=jochen for stray gyp files.
>
> Committed: https://crrev.com/adce7da2534641a5385eabd8f25e9379e4f3ab27
> Cr-Commit-Position: refs/heads/master@{#374046}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337

Review URL: https://codereview.chromium.org/1676093002

Cr-Commit-Position: refs/heads/master@{#374050}
darwin added a commit that referenced this issue Feb 9, 2016
@darwin
squash 'resources/unpacked/devtools' changes from d8952e0..5f3b8e4
2191f54 
5f3b8e4 Revert of DevTools: do not use platform/ to load injected scripts into inspector/v8. (patchset #3 id:100001 of https://codereview.chromium.org/1670813003/ )
0d97c97 DevTools: do not use platform/ to load injected scripts into inspector/v8.
d4a86f2 Revert "Devtools: Add metrics for drawer views being shown"
49d18c4 DevTools: remove dependency on ScriptRegexp.h, CodeSearchUtils.h from inspector/v8.
96f1331 DevTools: convert ScriptCallStack into a wrapper around the V8StackTrace backend.
7662cd1 DevTools: Fix sorting by type in network panel
d757306 DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.
a7db135 DevTools: move compile/runScript from debugger agent into the runtime one.
ad89e1b DevTools: early prototype of rail phases detection on Timeline
02efb97 Devtools: Enable dark inspect tooltip
95381fc DevTools: removing the deprecated timeline domain.
f2193dc [DevTools] Implement auto attach to popups.
fd477cd Surface SCT (Signed Certificate Timestamp) counts in the Security panel.
0e4a123 [DevTools] Fixing UX regressions.
0749e47 [DevTools] Polyfill Object.observe for old frontends.
f91bb92 Fixes #575026 : DevTools CPU Flamechart - use node.url to assign color to flamecharts rather than node.functionName:node.url
e2d7888 DevTools: Search across all files doesn't find all text in the webapp
e851989 [DevTools] Use Debugger.setBlackboxedRanges for blackboxing
3373105 Accessibility pane: Show related nodes inline
a07d3fe [DevTools] Add Debugger.setBlackboxedRanges protocol method
5aba73f Modify presentation of related nodes in Accessibility pane
a652569 Revert of Change Event.deepPath to a method (patchset #3 id:40001 of https://codereview.chromium.org/1637813002/ )
6c0bf8d Rename first-party-only cookies to same-site cookies.
ba41625 Change Event.deepPath to a method
30d9fd5 DevTools: support snippets with names of Object.prototype methods
edbea8f DevTools - Elements dim the "== $0"
c0ea2dd [DevTools] Provide reasonable default values when adding custom device.
5307a20 Devtools: Accept applied autocompletion on property edit blur
91078bd [DevTools] Device mode: resizer at the left, removed annoying console error.
7be6b68 [DevTools] Reset page scale before applying new emulation parameters.
6cf35e7 [DevTools] Cleanup various bindInput implementations.
0ba43a8 DevTools: support fixed-width columns in data grid
a83ce24 DevTools: [timeline] Make events with no JS stacks placed correctly.
90ab3fc DevTools: Color system JS frames with scripting category color.
e00beec [DevTools] Small cleanup after device mode v2.
74c6a34 Devtools: Add editable keyframes to the styles sidebar pane
85dee60 DevTools: Switch to using fast stack iterator to collect stacks during timeline recording.
9b72e0f Add Tracing.RecordClockSyncMarker to DevTools API
d8af5fb DevTools: move InjectedScript* to inspector/v8.
0e1259e [DevTools] Split DeviceModeView.js into view, toolbar and wrapper.

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: 5f3b8e4
babot pushed a commit that referenced this issue Mar 25, 2016
Revert of [DevTools] Use InspectorFrontendHost.readyForTest for layou…
2c06e0c 
…t tests. (patchset #3 id:40001 of https://codereview.chromium.org/1819243002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-reload.html is flaky

BUG=597572

Original issue's description:
> [DevTools] Use InspectorFrontendHost.readyForTest for layout tests.
>
> BUG=none
>
> Committed: https://crrev.com/89f7238cebbf5d77e4caa84d0a2750f6faa7e983
> Cr-Commit-Position: refs/heads/master@{#383015}

[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1828983002

Cr-Commit-Position: refs/heads/master@{#383053}
darwin added a commit that referenced this issue Mar 31, 2016
@darwin
squash 'resources/unpacked/devtools' changes from 791c2d1..3284500
a829a47 
3284500 DevTools: use standard tabbed pane and widgets for the service workers view.
11923aa DevTools: enable capture screen with device art.
3107a42 [DevTools] Fix bug with WebSockets flipping frames
d3630b9 DevTools: do not run acorn in the UI thread
25c1120 Devtools: Add trigger add to homescreen to command menu
b396261 Devtools: Remove non-existant empty cache, hard reload from command menu BUG=589353
d9247b7 Devtools Animations: Correctly sync scrubber when first animation ended
c3bd2dc [DevTools] Check mappings.length in  BlackboxManager on SourceMap loaded
093c952 DevTools: [SSP] accept editing on mouse click
b270b46 [DevTools] Fixed context menu breakage when edit dom in console
9d536f7 Devtools: Add screenshot button to device mode toolbar.
974c4c0 DevTools: request app banner from DevTools without #enable-add-to-shelf flag while emulating.
ab84c2c DevTools: [SASS] improve scss parser
93559b1 [DevTools] Added serverIPaddress to HAR output
dea4302 DevTools: use standard UI widget for the service workers toolbar.
6eac01e DevTools: [SASS] simplify SCSS parsing
4f27144 DevTools: simplify WI.FormattedContentBuilder
8d1bea1 [DevTools] Add DebuggerScript.js compilation to compile_frontend.py
8c3efc3 [DevTools] Introduced WebInspector.LiveLocationPool
e81e238 DevTools: introduce liveSASS hidden experiment
5747abb [DevTools] Remove promise inspector experiment
be19483 DevTools: [CSS] reload sourcemap as SASS watchdog updates CSS file
1b214ef Added regex support in search for network tab
bcf3547 Show v8.parseOnBackground in DevTools Timeline
3cc3585 DevTools: Refactor CPU profiler: get rid of data object.
cf35d4d [DevTools] Use InspectorFrontendHost.readyForTest for layout tests.
c87aaf6 [DevTools] Add a bunch of emulation actions to command menu.
a02e528 DevTools: make Timeline flame chart nice again.
12affcb SourceFrame implements Search interface SourceFrame should now implement Search interface.
6b8f8a8 DevTools: [ux regression] There is no way to clear console history.
fbd4149 Handle the case for older releases (pre M51) by adding CSS fixes in compatibility script to handle the case of a border-image element that lacks the border-style.
2c06e0c Revert of [DevTools] Use InspectorFrontendHost.readyForTest for layout tests. (patchset #3 id:40001 of https://codereview.chromium.org/1819243002/ )

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: 3284500
babot pushed a commit that referenced this issue Apr 16, 2016
@caseq
Revert of DevTools: extract CPU profile independent part of CPUProfil…
c0fed8a 
…eNode. (patchset #3 id:40001 of https://codereview.chromium.org/1873973002/ )

Reason for revert:
This broke at least two timeline tests with Cannot read property 'parent' of null

BUG=603767

Original issue's description:
> DevTools: extract CPU profile independent part of CPUProfileNode.
>
> This is a prerequisite to make the profile node class reused for sampling heap profiler.
>
> BUG=586613
>
> Committed: https://crrev.com/1c33b9ee4940826b3a972c093cbc3f8e1f1b3f50
> Cr-Commit-Position: refs/heads/master@{#387249}

[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=586613

Review URL: https://codereview.chromium.org/1889963003

Cr-Commit-Position: refs/heads/master@{#387716}
darwin added a commit that referenced this issue Apr 20, 2016
@darwin
squash 'resources/unpacked/devtools' changes from 61e53c7..ea1001a
47be2d5 
ea1001a [DevTools] Support broken UMA metric from M49 frontend.
e42e78a Revert of [DevTools] Added keyboard search while in sources (patchset #7 id:120001 of https://codereview.chromium.org/1831903002/ )
b3fb203 DevTools: teach SourceMapNamesResolver to resolve "this" object
c0fed8a Revert of DevTools: extract CPU profile independent part of CPUProfileNode. (patchset #3 id:40001 of https://codereview.chromium.org/1873973002/ )
decf4d4 DevTools: improve identifier extraction in SourceMapNamesResolver
e2ca0ad Rename Heap to ThreadHeap
8228bda Revert of Rename Heap to ThreadHeap (patchset #13 id:240001 of https://codereview.chromium.org/1845543002/ )
2a81c34 DevTools: extract CPU profile independent part of CPUProfileNode.
53d311c Rename Heap to ThreadHeap
b095eff [DevTools] Fix autocomplete for iframe in top context
81abc28 DevTools: add -webkit-user-select and -webkit-user-modify completions
93a9291 DevTools: cleanup occurences of selection.getRangeAt to avoid NPE
bb4305f [DevTools] Fix console history for evaluated object literals
18c6c34 [DevTools] Fix condition in ElementsTreeElement.js
4264bde DevTools: workaround bug in Blink selection API
81e05cb DevTools: deprecate InspectorTest.runAfterPendingDispatches
2dda9ca [DevTools] Added keyboard search while in sources

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: ea1001a
babot pushed a commit that referenced this issue May 3, 2016
@dpranke
Revert of Fixed DevTools event-listener breakpoints for PointerEvents…
78782d0 
…. (patchset #3 id:40001 of https://codereview.chromium.org/1915623002/ )

Reason for revert:
Reverting this, one of the tests is timing out in debug builds:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/1480/steps/webkit_tests/logs/stdio

Original issue's description:
> Fixed DevTools event-listener breakpoints for PointerEvents.
>
> Also added a test with PointerEvent specific expectation, in
> the "pointerevent" virtual suite.
>
> BUG=605706
>
> Committed: https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60
> Cr-Commit-Position: refs/heads/master@{#390988}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605706

Review-Url: https://codereview.chromium.org/1935373002
Cr-Commit-Position: refs/heads/master@{#391113}
darwin added a commit that referenced this issue May 4, 2016
@darwin
squash 'resources/unpacked/devtools' changes from 064127e..4150aff
5d1141c 
4150aff DevTools: [SASS] start parsing CSS with SCSS parser
51b0ebb DevTools: [SASS] parse SCSS rules and their selectors.
292d4f9 Revert of DevTools: fix focus restoration from command menu (patchset #4 id:60001 of https://codereview.chromium.org/1922303004/ )
d79bed2 DevTools: fix styles in rendering pane
d21c547 DevTools: properly update close icon in search field
dab74b9 DevTools: Reorder timeline checkboxes.
05809f9 DevTools: mute the node highlight & hide devtools while taking screenshots.
a3b8435 Security panel: add listeners only to the added target.
f4f510c [DevTools] 20px default top inset gutter to avoid Ruler overlap in emulation mode
f2b80ce Fix issue causing no cookies to be shown in the Resources > Cookies panel.
78782d0 Revert of Fixed DevTools event-listener breakpoints for PointerEvents. (patchset #3 id:40001 of https://codereview.chromium.org/1915623002/ )
0af8110 Timeline: use RAIL phases to color input events
8939357 DevTools: fix user agent custom behavior
9f84e26 DevTools: fix focus restoration from command menu
68642cb [Devtools] isTrusted in CustomEvents shown twice in console
4a00752 DevTools: brush up command menu looks, render badges.
81dfcdf DevTools: fix visual regressions in full text search
d329629 [Devtools] Fix to XMLView in Network Preview panel broken
42f1d67 DevTools: Move network pane on timeline out of experiment
0e0cd5c Fixed DevTools event-listener breakpoints for PointerEvents.
3a717ab [DevTools] Add base JS Proxy support

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: 4150aff
babot pushed a commit that referenced this issue Jul 22, 2016
@aslushnikov
Revert of DevTools: keep widgets in widget hierarchy upon hide, split…
5db55e4 
… attach/detach cycle from show/hide. (patchset #3 id:40001 of https://codereview.chromium.org/2157363006/ )

Reason for revert:
REverting as this broke devtools on Tip-of-tree

[17701:17701:0721/140403:ERROR:CONSOLE(266)] "Uncaught (in promise) NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.", source: chrome-devtools://devtools/bundled/ui/Widget.js (266)

TBR=pfeldman, dgozman

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2170063002
Cr-Commit-Position: refs/heads/master@{#406938}
darwin added a commit that referenced this issue Jul 27, 2016
@darwin
squash 'resources/unpacked/devtools' changes from 1e8a509..6bad132
5e38e1d 
6bad132 Revert of DevTools: cleanup treeoutline expand logic (patchset #1 id:1 of https://codereview.chromium.org/2147343002/ )
88a154f DevTools: update css for Remote Devices drawer panel
8f09224 [DevTools] Better locations for snippets
2990ca1 DevTools: follow up to the widget hierarchy change, account for local widget reparending.
0e53c6c [DevTools] No longer store security origins in RTM
30fcf52 [DevTools] Do not use "settings" query param.
d981140 DevTools: traverse widget hierarchy to reveal views.
6b52111 DevTools: disable "lineWiseCopyCut" CodeMirror option.
b452544 DevTools: update list of CSS properties that are color aware
89338eb [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.
c6c550c DevTools: follow-up to view introduction, fix styles css.
a5c233d DevTools: roll CodeMirror 5.17.1 Fixing soft undo
01a9c01 DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide (reland)
5d69fad DevTools: Allow ESC for source color picker
3da8d7c DevTools: Sourcemap failure shouldn't open console drawer.
840152b DevTools: [SSP] simplify Control-Click functionality
5881e0a DevTools: remove isTrusted check and isUserGesture from ViewportControl
312effe DevTools: cleanup treeoutline expand logic
6f1379d DevTools: Fix Ctrl-Z for source color picker
e40d1a8 DevTools: Immediately hide on scroll for source color picker
4c68e86 DevTools: make all timeline trace events use 0-based line numbers
5db55e4 Revert of DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. (patchset #3 id:40001 of https://codereview.chromium.org/2157363006/ )
e0158a2 DevTools: Set mouse cursor to default when hovering over color swatch
4c0368e DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide.
5dc7504 DevTools: fix computed style pane layout
02e7968 DevTools: Added package.json, LICENSE, and .npmignore
1834b66 DevTools: Fix presubmits failing on InspectorFrontendHostAPI
d253713 DevTools: Add reload button to disconnection dialog
b520ad6 [DevTools] Remove Object.values and Object.isEmpty from utilities.js
dc02602 DevTools: Change a few implicit globals to explicit globals.
0bce15a DevTools: Source color picker experiment. Make color swatches clickable
1db2194 DevTools: roll front_end/sdk/protocol files
76bb451 [DevTools] Move "Continue to first invocation" experiment to hidden
b5b583f [DevTools] Make NetworkAgent.Initiator 0-based
e8262af DevTools: introduce View: a named widget with the toolbar.
939b708 [DevTools] Make WebInspector.ConsoleMessage 0-based
8f6d4b9 DevTools: Use proper target when processing worker thread events.
44c007e DevTools: remove WI.SourcesView._currentUISourceCode
487b5e0 [DevTools] Introduce DOM capability.
48e8a60 [DevTools] Move browser logging from Console domain to Log domain.
7228d61 DevTools: Move WebInspector.SwatchPopoverHelper into new file ui/SwatchPopoverHelper.js
b7d17e5 [DevTools] Remove toProtocolValue from v8_inspector/public.
8d097c0 [DevTools] Fix links for JSFrame records in timeline
5915191 Remove FileError interface
9cfcb7a Fix compilation error after r406140
1b8616a Revert of Make the extension's sidebar pane auto-resizable. (patchset #7 id:120001 of https://codereview.chromium.org/1905493002/ )
f0cd1db DevTools: Do not linkify to pseudo (program) node when there's no URL
91ab1e8 [Devtools] Code cleanup - ensure no double-semicolons
debf816 DevTools: Added empty implementation of navigationRequested method in frontend
888e1a8 DevTools: Rename StylesPopoverHelper to SwatchPopoverHelper

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: 6bad132
@darwin
Copy link
Member Author

darwin commented Sep 3, 2016

Reposted as #36

@darwin darwin closed this as completed Sep 3, 2016
babot pushed a commit that referenced this issue Nov 9, 2016
@aslushnikov
Revert of DevTools: isolate settings of custom devtoools front-end. (…
68ac4b2 
…patchset #3 id:40001 of https://codereview.chromium.org/2474563002/ )

Reason for revert:
Reverting this patchset since it doesn't fully address problem. LocalStorage settings still clash.

Original issue's description:
> DevTools: isolate settings of custom devtoools front-end.
>
> Currently, changing a setting inside custom devtools front-end (the one
> served through chrome-devtools://devtools/custom) will change the same
> setting inside bundled devtools.
>
> This is unfortunate. In the setup we aim for, the custom devtools
> are inspected by the bundled devtools, and we want them to be
> independent of each other.
>
> This patch starts using local storage for the settings of the
> chrome-devtools://devtools/custom front-end.
>
> Note: settings will be isolated, whereas experiments won't.
>
> BUG=629914
> R=dgozman
>
> Committed: https://crrev.com/16056dbccd68723d61feaf6e9a9518a300485c2c
> Cr-Commit-Position: refs/heads/master@{#429414}

[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=629914

Review-Url: https://codereview.chromium.org/2483333003
Cr-Commit-Position: refs/heads/master@{#430814}
darwin added a commit that referenced this issue Nov 10, 2016
@darwin
squash 'resources/unpacked/devtools' changes from 64149c4..dc60498
8ec4a7b 
dc60498 [DevTools] Migrate toolbar to use WI.Icon.
cd02903 DevTools: introduce WI.Icon to handle icons with ease
ab7defa [DevTools] observe target in BreakpointManager
68ac4b2 Revert of DevTools: isolate settings of custom devtoools front-end. (patchset #3 id:40001 of https://codereview.chromium.org/2474563002/ )
c5e6d7e DevTools: clicking console messages with traces should check for links
8e97a26 [Devtools] Renamed Network's Timeline to Waterfall
a3a38a5 DevTools: Button for 'Add a folder to workspace'
13a9f03 DevTools: add per-frame grouping into aggregated timeline details
c33ab00 DevTools: teach automapping to deal with network resources with file:// urls
6bf561f DevTools: eliminate ToolbarButton.setState method; cleanup toolbar.css
336360e [Devtools] Added padding to hover area in network timeline

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: dc60498
babot pushed a commit that referenced this issue Apr 29, 2017
@a1ph
Revert of DevTools: Show screenshots on the main flamechart (patchset #3
ef9fa0f 
 id:40001 of https://codereview.chromium.org/2830343004/ )

Reason for revert:
Panning does not work, as well as HiDPI.

Original issue's description:
> DevTools: Show screenshots on the main flamechart
>
> The patch puts the screenshots on the frame bar and makes it expandable.
>
> BUG=705054
>
> Review-Url: https://codereview.chromium.org/2830343004
> Cr-Commit-Position: refs/heads/master@{#466821}
> Committed: https://chromium.googlesource.com/chromium/src/+/575cce8631ed083645523d47a35090d6ca6ccdfd

[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=705054

Review-Url: https://codereview.chromium.org/2854473002
Cr-Commit-Position: refs/heads/master@{#468116}
darwin added a commit that referenced this issue Apr 29, 2017
@darwin
squash 'resources/unpacked/devtools' changes from 51d8180..30ad697
452e532 
30ad697 [Devtools] New structure and colorize rows for network products
d46aaf6 [Devtools][Regression] Fixed websocket frame selection loss on frame received
fb9c652 DevTools: Don't focus layers panel when it is shown
ba54910 Reland of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2839083002/ )
ef9fa0f Revert of DevTools: Show screenshots on the main flamechart (patchset #3 id:40001 of https://codereview.chromium.org/2830343004/ )
a75caae [DevTools] Host paint profiles in PaintProfilerModel
97e8024 DevTools: clicking in console messages should not jump to bottom

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: 30ad697
babot pushed a commit that referenced this issue May 4, 2017
@caseq
Revert of DevTools: support resolving a UILocation to multiple raw sc…
dff718f 
…ript locations (patchset #3 id:60001 of https://codereview.chromium.org/2857453002/ )

Reason for revert:
We decided that we don't need that.

Original issue's description:
> DevTools: support resolving a UILocation to multiple raw script locations
>
> This turns uiLocationToRawLocation into uiLocationToRawLocations and makes it return an array
>
> BUG=717694
>
> Review-Url: https://codereview.chromium.org/2857453002
> Cr-Commit-Position: refs/heads/master@{#468825}
> Committed: https://chromium.googlesource.com/chromium/src/+/421b9c4b9736e52c903123994d977b4ed406cf72

[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=717694

Review-Url: https://codereview.chromium.org/2859073002
Cr-Commit-Position: refs/heads/master@{#469206}
darwin added a commit that referenced this issue May 5, 2017
@darwin
squash 'resources/unpacked/devtools' changes from 87b161b..e71b776
6e78bbc 
e71b776 DevTools: fix 'Make a copy' context menu item in navigator
99bb354 DevTools: get rid of hand-crafted binary search in SourceMap.findEntry
c3b7bfe [Devtools] Restructure network nodes for friendlier products/grouping
aeac81e [DevTools] Enable "auto attach to sub frames" by default
1bbdb1c DevTools: add command menu entries for adding new snippet, workspace folder
f950ef8 DevTools: support uiLocationToRawLocations for CSS
cab282d DevTools: Roll lighthouse w/ artifact delivery
ab11d5c [Devtools] Fix network grouping experiment
624ea04 DevTools: Migrate from -webkit-user-modify to contenteditable
dff718f Revert of DevTools: support resolving a UILocation to multiple raw script locations (patchset #3 id:60001 of https://codereview.chromium.org/2857453002/ )
59c0d0a DevTools: Fix "Unwanted blue dot is seen in 'Performance' section of devtools"
85245cf DevTools: Make domains promisified by default
7cefcda DevTools: Remove script/OWNERS

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: e71b776
babot pushed a commit that referenced this issue May 14, 2017
@justindonnelly
Revert of DevTools: format keys in object previews using sans serif. …
03f7c18 
…(patchset #3 id:40001 of https://codereview.chromium.org/2866363003/ )

Reason for revert:
This change broke webkit_tets on multiple builders. See, for example:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/26454

Original issue's description:
> DevTools: format keys in object previews using sans serif.
>
> NOTRY=try
>
> Review-Url: https://codereview.chromium.org/2866363003
> Cr-Commit-Position: refs/heads/master@{#471578}
> Committed: https://chromium.googlesource.com/chromium/src/+/14981e159fc950c0a628869e85c166c6c09809ca

[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2878243002
Cr-Commit-Position: refs/heads/master@{#471584}
darwin added a commit that referenced this issue May 14, 2017
@darwin
squash 'resources/unpacked/devtools' changes from 2342364..a5b99cb
d2d68b3 
a5b99cb [DevTools] Handle more cases for async step in markers
49ff603 force non-overlay scrollbars in all platform in flamechart
03f7c18 Revert of DevTools: format keys in object previews using sans serif. (patchset #3 id:40001 of https://codereview.chromium.org/2866363003/ )
3ce67c1 Revert of DevTools: render product badges behind the setting. (patchset #6 id:100001 of https://codereview.chromium.org/2879943003/ )

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: a5b99cb
babot pushed a commit that referenced this issue May 18, 2017
Revert of DevTools: Roll Lighthouse binary to 2.0.0-alpha.7 (patchset #3
544b916 
 id:20001 of https://codereview.chromium.org/2888263002/ )

Reason for revert:
Breaks devtools_closure_compile and devtools_eslint: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/56719

Original issue's description:
> DevTools: Roll Lighthouse binary to 2.0.0-alpha.7
> Hash: aebc9bdf53754ffd360f7c54c752b046383c2d1b
>
> BUG=663085
> [email protected], [email protected]
>
> Review-Url: https://codereview.chromium.org/2888263002 .
> Cr-Commit-Position: refs/heads/master@{#472680}
> Committed: https://chromium.googlesource.com/chromium/src/+/5b84a98141df91643a05bcb8e81c9f0398e6ba81

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=663085

Review-Url: https://codereview.chromium.org/2887313002 .
Cr-Commit-Position: refs/heads/master@{#472746}
darwin added a commit that referenced this issue May 19, 2017
@darwin
squash 'resources/unpacked/devtools' changes from adf7209..18b86b0
2dead10 
18b86b0 DevTools: WebSocketFrameView - Add frames display control toolbar
544b916 Revert of DevTools: Roll Lighthouse binary to 2.0.0-alpha.7 (patchset #3 id:20001 of https://codereview.chromium.org/2888263002/ )
d658f9a [DevTools] Show icon in top toolbar when Node target is available
993b27c DevTools: Roll Lighthouse binary to 2.0.0-alpha.7 Hash: aebc9bdf53754ffd360f7c54c752b046383c2d1b
b0155de DevTools: Show badges instead of products in ConsoleContextSelector
d5903af [Devtools][Regression] Fixed network film strip sometimes errored
123fed4 [DevTools] breakpoint manager should be ready for location from different model
47fe6ba DevTools: fix exception on heap snapshot error reporting.
fe59089 DevTools: prep audits panel for Lighthouse roll
a606325 [Devtools] Updated frontend version to 24 - remove products column
b1a60f2 [DevTools] update decorations when there is no pending possibleBreakpoints

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: 18b86b0
babot pushed a commit that referenced this issue Jun 10, 2017
@dgozman
Revert of [DevTools] Show icon in top toolbar when Node target is ava…
6b26576 
…ilable (patchset #3 id:40001 of https://codereview.chromium.org/2890973002/ )

Reason for revert:
See issue 727517

Original issue's description:
> [DevTools] Show icon in top toolbar when Node target is available
>
> Clicking on it opens dedicated Node frontend.
>
> BUG=706916
>
> Review-Url: https://codereview.chromium.org/2890973002
> Cr-Commit-Position: refs/heads/master@{#472739}
> Committed: https://chromium.googlesource.com/chromium/src/+/ad3ffab411cc396ffb20c1d35dcff6de038f14b4

[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=706916

Review-Url: https://codereview.chromium.org/2932703002
Cr-Commit-Position: refs/heads/master@{#478017}
darwin added a commit that referenced this issue Jun 10, 2017
@darwin
squash 'resources/unpacked/devtools' changes from 8f5fe51..f044be5
699cf5a 
f044be5 DevTools: Add setting to toggle default mouse wheel scroll/zoom flamechart behavior.
ceced39 DevTools: support object destructuring in pretty print
8ecaab1 DevTools: Fix isCaretAtEndOfPrompt if ghost text is visible
89b7146 DevTools: remove stray error messages while devtools on devtools.
9a11b0d DevTools: Avoid reflow when selecting items in TreeOutline
29c0f8f ChromeDriver: Handle key events properly on Mac
daf5c5e DevTools: add use strict in check gn
39dc3c9 DevTools: Account for border when measuring StylesSidebarPane section
be7df7e DevTools: Clean up selection
26630bd DevTools: Make the performance recording 'Stop' button default.
49541bc Revert "DevTools: remove stray error messages while devtools on devtools."
42660a4 DevTools: migrate ComputedStyleWidget to shadow
312df77 DevTools: Promisify searchInContent calls.
f3c2a82 DevTools: kill DebuggerWorkspaceBinding.{push,pop,set}SourceMapping
ea2a4d8 DevTools: remove stray error messages while devtools on devtools.
7ac8e75 Timeline: fix saving when switching models trough history dialog
44b1ff8 DevTools: check BUILD.gn file as part of PRESUBMIT
8a42b07 Added refresh button to category view of cache storage and indexeddb
74345fa Right-click 'Refresh' on database now updates object store view, also fixed IndexedDB view crash.
fd95b42 DevTools: remove UIString.capitalize.
1f347da DevTools: Avoid a race in WorkspaceDiff when UISourceCodes are removed
6b26576 Revert of [DevTools] Show icon in top toolbar when Node target is available (patchset #3 id:40001 of https://codereview.chromium.org/2890973002/ )
514aac9 DevTools: Limit screenshot overview popover height.
3bb3592 DevTools: migrate MetricsSidebarPane to shadow
573c227 DevTools: reveal and highlight dom nodes when searching in elements panel.
ba9bc87 DevTools: Extract formatter module
6c19df3 DevTools: rename Multimap.(remove|removeAll) into delete and deleteAll
9da32f8 DevTools: migrate SSP Classes and ElementState toolbar widgets to shadow
87b2fbd DevTools: make EventListenersView a proper widget
a552498 DevTools: fix offset condition in console viewport _selectedText and add tests
3c20bd7 DevTools: Add close button to Audits2 dialog
68603e6 DevTools: linkify terminal errors in the term extension.
5b62640 DevTools: Promisify domains clean up

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: f044be5
babot pushed a commit that referenced this issue Jun 17, 2017
@dgozman
Reland of [DevTools] Show icon in top toolbar when Node target is ava…
0442011 
…ilable (patchset #1 id:1 of https://codereview.chromium.org/2932703002/ )

Reason for revert:
Fixed the original crash cause

Original issue's description:
> Revert of [DevTools] Show icon in top toolbar when Node target is available (patchset #3 id:40001 of https://codereview.chromium.org/2890973002/ )
>
> Reason for revert:
> See issue 727517
>
> Original issue's description:
> > [DevTools] Show icon in top toolbar when Node target is available
> >
> > Clicking on it opens dedicated Node frontend.
> >
> > BUG=706916
> >
> > Review-Url: https://codereview.chromium.org/2890973002
> > Cr-Commit-Position: refs/heads/master@{#472739}
> > Committed: https://chromium.googlesource.com/chromium/src/+/ad3ffab411cc396ffb20c1d35dcff6de038f14b4
>
> [email protected]
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=706916
>
> Review-Url: https://codereview.chromium.org/2932703002
> Cr-Commit-Position: refs/heads/master@{#478017}
> Committed: https://chromium.googlesource.com/chromium/src/+/24309d877571d159bc14f871671ff0630d6f8d32

[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=706916,727517

Review-Url: https://codereview.chromium.org/2939173002
Cr-Commit-Position: refs/heads/master@{#479882}
babot pushed a commit that referenced this issue Jan 26, 2018
@tasak
Revert "Fix retargeting of result in elementFromPoint and elementsFro…
047b74b 
…mPoint"

This reverts commit dd944882a245a5117b50cb417138d92f32d931d6.

Reason for revert: 
This causes WebKit Linux Trusty ASAN buildbot failure.
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/8618

23:46:29.565 3877   ==1==ERROR: AddressSanitizer: use-after-poison on address 0x7ead60c0dbf0 at pc 0x00000dca937a bp 0x7ffd86b90c10 sp 0x7ffd86b90c08
23:46:29.565 3877   READ of size 8 at 0x7ead60c0dbf0 thread T0 (content_shell)
23:46:29.565 3877       #0 0xdca9379 in operator==<const blink::TreeScope, const blink::TreeScope> third_party/WebKit/Source/platform/heap/Member.h:128:27
23:46:29.565 3877       #1 0xdca9379 in blink::TreeScope::Retarget(blink::Element const&) const third_party/WebKit/Source/core/dom/TreeScope.cpp:393:0
23:46:29.565 3877       #2 0xdca8894 in blink::TreeScope::HitTestPointInternal(blink::Node*) const third_party/WebKit/Source/core/dom/TreeScope.cpp:267:10
23:46:29.565 3877       #3 0xdca8325 in HitTestPoint third_party/WebKit/Source/core/dom/TreeScope.cpp:254:10
23:46:29.566 3877       #4 0xdca8325 in blink::TreeScope::ElementFromPoint(double, double) const third_party/WebKit/Source/core/dom/TreeScope.cpp:245:0
23:46:29.566 3877       #5 0xc9353a7 in elementFromPoint third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h:38:23



Original change's description:
> Fix retargeting of result in elementFromPoint and elementsFromPoint
> 
> Currently elementFromPoint and elementsFromPoint are not per spec, and it may
> return null incorrectly. This change adds retargeting of the result with
> respect to the context object, and adds some tests that are similar to
> elementFromPoint tests in WebKit, but with some corrected cases:
> https://git.webkit.org/?p=WebKit-https.git;a=blob;f=LayoutTests/fast/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html;h=a8dc4da2430713521b9ba77c742db10397a8e638;hb=HEAD
> 
> Spec:
> https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin
> 
> Bug: 759947
> Change-Id: I6aece5e9cc826124772c6ce13c806865055b2b9b
> Reviewed-on: https://chromium-review.googlesource.com/808446
> Commit-Queue: Rakina Zata Amni <[email protected]>
> Reviewed-by: Dmitry Gozman <[email protected]>
> Reviewed-by: Hayato Ito <[email protected]>
> Reviewed-by: Takayoshi Kochi <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#531139}

[email protected],[email protected],[email protected],[email protected],[email protected]

Change-Id: Id62abd371d93627d3178b63ca189cecfe9ff44d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 759947
Reviewed-on: https://chromium-review.googlesource.com/880264
Reviewed-by: Takashi Sakamoto <[email protected]>
Commit-Queue: Takashi Sakamoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#531178}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@darwin