Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect equation #10

Open
Ryan-Bringenberg opened this issue Jan 26, 2023 · 1 comment
Open

Incorrect equation #10

Ryan-Bringenberg opened this issue Jan 26, 2023 · 1 comment

Comments

@Ryan-Bringenberg
Copy link
Contributor

The current formula used is a simplification of
formula: min + (max - min)/(1 + (x/ic50)^hill
where the minimum response is 0. However, according to this mathworks (see link below), the hill coefficient should be negative.

https://www.mathworks.com/matlabcentral/fileexchange/38124-three-parameters-logistic-regression-there-and-back-again#:~:text=The%25203PL%2520equation%2520is%253A%2520F%2520%2528x%2529%2520%253D%2520D%252F,curve.%2520It%2520could%2520either%2520be%2520positive%2520or%2520negative.

Ryan-Bringenberg added a commit to Ryan-Bringenberg/pyzyme that referenced this issue Jan 26, 2023
fixed equation, see issue bio-ml#10.
@iansind
Copy link
Member

iansind commented Jan 26, 2023

The Hill coefficient directionality depends on whether inhibition or promotion is occuring. This will be added when objects are implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants