Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider re-use of OLS source code #2

Open
joncison opened this issue Dec 12, 2017 · 3 comments
Open

Consider re-use of OLS source code #2

joncison opened this issue Dec 12, 2017 · 3 comments

Comments

@joncison
Copy link
Member

OLS have done a great job at browsing EDAM:
https://www.ebi.ac.uk/ols/ontologies/edam

And their source code (for the full-fledged web application) is available under open license:
https://www.ebi.ac.uk/ols/docs/installation-guide

So I think this has to be under consideration for future development of edamToolAnnotator.

We can park the issue for now, but one for the future.

cc @hansioan @hmenager

@hansioan
Copy link
Member

Looking at the software requirements of OLS it seems that it might be unfeasible to integrate.
I wrote the annotator with the specific intent of integrating it in bio.tools, thus I have used most of the stuff (including version) that is currently present in bio.tools.
The annotator is basically an Angular (JavaScript) app with no server-side or database components. Furthermore, OLS uses jQuery for the front-end which is ok, but I would like to move ahead with the technology. Nothing wrong with jQuery, but newer JavaScript-based stuff is out now.

The only use case I would see for it would be maybe if people don't want to use Angular when integrating the annotator, then jQuery is vanilla enough to use, but that would mean a separate annotator written in jQuery only.

@joncison
Copy link
Member Author

joncison commented Dec 12, 2017

Understood - of course I hope it gets in bio.tools soon.

The big benefit though is we'll struggle (never?) get a tree browser that comes close to being as good as OLS ... Jupp spent ages on it - this bit would be good to re-use if poss. Just food for thought ...

@hansioan
Copy link
Member

I think for now, what we can do is point each term to OLS, as a separate link in the annotator information panel, where all the term info is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants