Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix: hscgd #1263

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add prefix: hscgd #1263

wants to merge 6 commits into from

Conversation

nagutm
Copy link
Collaborator

@nagutm nagutm commented Nov 19, 2024

This pull request curates a new prefix hscgd based on the following PubMed paper: https://pubmed.ncbi.nlm.nih.gov/39470706/
This resource provides identifiers for single-cell whole-genome sequencing data.

Each entry consists of a 'Project accession' that is resolvable using the uri_format and used as the primary identifier for this resource. In addition to that, there are separate pages with unique identifiers for 'Sample accessions' that correspond to each 'Project accession' and 'Run accessions' that correspond to each 'Sample accession'. The Sample and Run accession pages are directly accessible from the page for the corresponding 'Project accession'. I considered curating the Project, Sample and Runs as separate sematic spaces, however I felt that the Project accession alone was sufficient enough to describe the main idea of the resource.

The database also lists specific 'IDs' for each project that are numbered sequentially, however it does not make a lot of sense to me to use that as the primary identifier.

@bgyori
Copy link
Contributor

bgyori commented Nov 26, 2024

Upon more detailed review, it appears that the project identifiers here are actually resolving ones from other namespaces, in particular, insdc.sra and ena.embl. Overall, we might want to classify this as not notable.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.48%. Comparing base (8950e70) to head (a90151d).
Report is 170 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1263      +/-   ##
==========================================
+ Coverage   42.51%   44.48%   +1.97%     
==========================================
  Files         117      118       +1     
  Lines        8327     8268      -59     
  Branches     1963     1358     -605     
==========================================
+ Hits         3540     3678     +138     
+ Misses       4582     4413     -169     
+ Partials      205      177      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants