Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new provider for pdb: dionysus #1282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add new provider for pdb: dionysus #1282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/bioregistry/data/bioregistry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86891,6 +86891,21 @@
}
],
"uri_format": "https://seq2fun.dcmb.med.umich.edu/furna/pdb.cgi?pdbid=$1"
},
{
"code": "dionysus",
"description": "DIONYSUS is a database of protein-carbohydrate interfaces, offering annotated data and tools for exploring interaction patterns and annotating proteins.",
"homepage": "www.dsimb.inserm.fr/DIONYSUS",
"name": "DIONYSUS",
"publications": [
{
"doi": "10.1093/nar/gkae890",
"pubmed": "39436020",
"title": "DIONYSUS: a database of protein-carbohydrate interfaces",
"year": 2024
}
],
"uri_format": "https://www.dsimb.inserm.fr/DIONYSUS/structure/$1"
Copy link
Contributor

@bgyori bgyori Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this and one problem here is that the example ID listed for pdb (2gc4) doesn't resolve in this resource, so the example link shown on the web would be broken.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resource only appears to import a filtered set of PDB IDs that are carbohydrate-containing structures and match specific keywords related to the classification tag used by PDB. This explains why 2gc4 cannot be resolved with this uri_format.

I'm not sure how much value there is to curating a provider that cannot resolve all IDs for its parent resource. I think we could consider marking this as not_notable instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think in itself it's a problem that not every ID is resolved, but I think overall not sure if it's worth adding this given the anticipation of the broken example link.

}
],
"publications": [
Expand Down
1 change: 1 addition & 0 deletions src/bioregistry/data/curated_papers.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,4 @@ pubmed relevant orcid date_curated relevancy_type pr_added notes
39341994 0 0009-0009-5240-7463 2024-10-15 not_identifiers_resource 1223
39345624 1 0009-0009-5240-7463 2024-10-19 new_publication 1223 Publication for sgd and sgd.pathways
39401100 1 0009-0009-5240-7463 2024-11-20 new_publication 1264 Publication for intact and intact.molecule
39436020 1 0009-0009-5240-7463 2024-11-25 new_provider 1282 Provider for PDB