Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display optional "description" in API metadata #236

Closed
andrewsu opened this issue Jun 9, 2022 · 7 comments
Closed

display optional "description" in API metadata #236

andrewsu opened this issue Jun 9, 2022 · 7 comments
Assignees

Comments

@andrewsu
Copy link
Member

andrewsu commented Jun 9, 2022

If a user wants to know what a given API is for (e.g., "repodb"), the best options now seem to be to search the API name and/or look at example records. We should also allow an optional "description" to be provided in the manifest.json metadata, which would optionally provide some human-readable description directly on the API page.

EDIT: Sorry, just realized I should probably have created this issue in https://github.com/biothings/pending.api/issues.. Feel free to recreate it over there if helpful.

@newgene
Copy link
Member

newgene commented Jun 22, 2022

__metadata__ should already allow to add optional fields like "description" or anything else. It should then be carried over to the /metadata endpoint:

https://github.com/erikyao/repoDB/blob/9ce8f57e84b08c880ebdfd2a513829aa7c1db353/manifest.json#L4-L8

Let's give it a try for the repodb data plugin, the pending API UI will need to be updated to display this "description" text when available.

@erikyao
Copy link
Contributor

erikyao commented Aug 2, 2022

After the bugfix (pending.api - Issue#77) and description augmentation (repoDB - PR#2) , repoDB API is updated. However the description is not shown.

I can see that the API page requests metadata from https://biothings.ncats.io/repodb/metadata, and the description is inside the response. Therefore I think it now boils down to a frontend problem.

To @newgene: shall we have @marcodarko involved?

@newgene
Copy link
Member

newgene commented Aug 2, 2022

Yes, web UI needs to be updated accordingly as well (@marcodarko)

@marcodarko
Copy link
Contributor

Working on this project right now, I'll add it to my PR

@marcodarko
Copy link
Contributor

Will be addressed in biothings/pending.api#78

@tokebe
Copy link
Member

tokebe commented Aug 24, 2022

Following up: has this issue been adequately addressed by the above merged PR / should this issue be closed?

@marcodarko
Copy link
Contributor

Descriptions are now available eg. repodb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants