-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate PFOCR options (strict, synonyms, all) for BTE use #778
Comments
These PFOCR options were defined earlier:
My previous opinion (lab Slack link) was to use
|
I vote for using "all" to maximize coverage and possible aggregate-based, pathway-level insights. As @colleenXu said above, if performance becomes an issue, then we can dial back to "synonyms" and then to "strict". But these are not preferred for biological research reasons. |
@ayushi-agrawal-gladstone @khanspers Please share your votes and reasoning on this issue... |
Assuming we are voting on "BTE's regular use", I agree with Alex to use "all" unless performance is an issue. But for results-augmentation module, Colleen's point about "these figures don't actually have these genes in them" makes a lot of sense and would argue for "strict" in that usage. |
I agree with Alex and Kristina and vote for using "all" provided there are no performance issues. |
great, let's go with "all" then. @everaldorodrigo what is the default if no additional parameter is provided (e.g., https://biothings.transltr.io/pfocr/query?q=associatedWith.pmc:PMC3255783)? |
Hi @andrewsu and everybody! The default is Reference: |
See convo in biothings/pending.api#148
Currently, the new BioThings PFOCR API with a parameter to choose between strict, synonyms, and all options is on BioThings-Translator-CI https://biothings.ci.transltr.io/pfocr
We'll want to choose what to use for BTE's regular use (x-bte annotation). And maybe think about the result-augmentation module?
Note: also consider adding pfocrUrl field to x-bte annotation for use. EDIT: see Alex Pico's advice on urls here NCATS-Tangerine/translator-api-registry#132
The text was updated successfully, but these errors were encountered: