Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flood limiter to chats #2970

Open
suddenwhipvapor opened this issue Nov 1, 2024 · 2 comments
Open

Add flood limiter to chats #2970

suddenwhipvapor opened this issue Nov 1, 2024 · 2 comments

Comments

@suddenwhipvapor
Copy link
Contributor

It was probably just a matter of time, and now that I think about it, strange it didn't happen sooner.
I noticed a moderation report in my instance about "spam", and then I went checking, there were 308 unread messages in Discussions or Assistance, can't remember which one anymore, as, after ascertaining the reported user was the one behind the garbage being posted, I immediately banned him and deleted everything.
He still managed to flood the chat with 300+ messages. Other than being a UX nightmare, this could be used as a means for DDoS one day, so I think there should be a measure to have the local client limit the total number of outgoing messages per time unit (10 per minute and 20 per 5 minutes? to be defined), and also remote clients refuse to relay new messages coming from the same profile, that overcome that limit (in case someone modifies his local code), just like lightning nodes will not relay gossip when it's been broadcasted at a rate higher than a certain value.

@suddenwhipvapor suddenwhipvapor changed the title Add spam limiter to chats Add flood limiter to chats Nov 1, 2024
@axpoems
Copy link
Contributor

axpoems commented Nov 2, 2024

We already have a prevention mechanism in place for this, which is the proof of work factor applied every time a message is sent. I have made a PR to increase the cost for public chat messages.
There is also an adjustment factor that the security manager can set and will propagate to the network.

@suddenwhipvapor
Copy link
Contributor Author

Interesting to know 👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants