Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All services errors to match application errors #18

Open
pete-rai opened this issue Jan 12, 2023 · 0 comments
Open

All services errors to match application errors #18

pete-rai opened this issue Jan 12, 2023 · 0 comments

Comments

@pete-rai
Copy link
Collaborator

Ambassador will return consistent error codes to the BBK core services. However, Ambassador returns body-less errors, which is not the same as BBK core - which always returns an error body. Even for 404 and 401s and such:

https://www.bit-broker.io/docs/api-conventions/errors/

Errors coming from any "fronting" component, should be changed to match this format. This includes the rate-limiter and auth-service. This is because the user should not be aware that the error is coming from a "fronting" service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant