On Battlefield as a namespaced user warnet logs <name of scenario> gives a permission error

[m3dwards]

On Battlefield as a namespaced user warnet logs gives a permission error

[pinheadmz]

does it work if you find the desired scenario in the inquirer menu of warnet logs ?

[mplsgrant]

It looks to me like a user in, say, namespace wargames-orange is calling warnet logs my-scenario, but the implicit --namespace is actually default.

warnet/src/warnet/control.py

Lines 363 to 364 in 7974c5d

	@click.option("--namespace", type=str, default="default", show_default=True)
	def logs(pod_name: str, follow: bool, namespace: str):

Since a user in wargames-orange cannot access default, they get an error.

That said, when users do not specify a namespace, we use get_mission which calls get_pod. These functions rely on simply retrieving the default namespace. That's why wargames logs just works.

When the users specify the scenario name, the default namespace comes into play, and this code gets called:

warnet/src/warnet/control.py

Lines 405 to 407 in 7974c5d

	try:
	pod = get_pod(pod_name, namespace=namespace)
	eligible_container_names = [BITCOINCORE_CONTAINER, COMMANDER_CONTAINER]

I think we should wrap the bare call to get_pod with a for loop that iterates over namespaces using get_namespaces. Something like this:

    try:
        pod = None
        for v1namespace in get_namespaces():
            namespace = v1namespace.metadata.name
            try:
                pod = get_pod(pod_name, namespace=namespace)
            except Exception:
                pass

        if not pod:
            print(f"Could not find: {pod_name}")
            sys.exit(1)