Skip to content

Commit

Permalink
#153: remove search spinner animation (#154)
Browse files Browse the repository at this point in the history
  • Loading branch information
macjohnny authored Jun 14, 2019
1 parent d7ea78d commit 54b4fd5
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 17 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.7.6
* Bugfix: spinner not visible after reopening select panel
[#153](https://github.com/bithost-gmbh/ngx-mat-select-search/issues/153)

Thanks to @saithis for reporting

## 1.7.5
* Bugfix: Avoid `Cannot read property 'attach' of undefined` when `<ngx-mat-select-search>`
is not inside a `<mat-option>` element with Angular 8
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ngx-mat-select-search",
"description": "Angular component providing an input field for searching / filtering MatSelect options of the Angular Material library.",
"version": "1.7.5",
"version": "1.7.6",
"license": "MIT",
"scripts": {
"ng": "ng",
Expand Down
1 change: 0 additions & 1 deletion src/app/mat-select-search/mat-select-search.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
[attr.aria-label]="ariaLabel"
/>
<mat-spinner *ngIf="searching"
[@enterAnimation]
class="mat-select-search-spinner"
diameter="16"></mat-spinner>

Expand Down
14 changes: 0 additions & 14 deletions src/app/mat-select-search/mat-select-search.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {
NINE,
SPACE, END, HOME,
} from '@angular/cdk/keycodes';
import { animate, state, style, transition, trigger } from '@angular/animations';
import { ViewportRuler } from '@angular/cdk/scrolling';
import { Subject } from 'rxjs';
import { delay, take, takeUntil } from 'rxjs/operators';
Expand Down Expand Up @@ -116,19 +115,6 @@ import { MatSelectSearchClearDirective } from './mat-select-search-clear.directi
multi: true
}
],
animations: [
trigger('enterAnimation', [
state('void', style({
opacity: 0
})),
state('*', style({
opacity: 1
})),
transition('void <=> *', [
animate('0.1s ease-out')
])
])
],
changeDetection: ChangeDetectionStrategy.OnPush
})
export class MatSelectSearchComponent implements OnInit, OnDestroy, AfterViewInit, ControlValueAccessor {
Expand Down

0 comments on commit 54b4fd5

Please sign in to comment.