Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python example for fixed bitrate ladder overwrites the video for each config generated #13

Open
bunrithlim opened this issue Dec 25, 2020 · 0 comments

Comments

@bunrithlim
Copy link

File: python\src\fixed_bitrate_ladder.py

When calling _create_mp4_muxing(), the same file name is used for all video configs (video_configurations[]). For multiple video configs, only a single video file is left at the end as all files overwrite each other. The file remaining is "video.mp4".

This can be fixed by adding the height and bitrate to the file name of the video generated. Each video file created will have a different filename.

Suggested fix

file_name="video-{0}x{1}.mp4".format(video_configuration.height, video_configuration.bitrate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant