-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql-ha] Fix issue where user password is not set when a different username is provided #24593
Conversation
… a different username is provided Signed-off-by: Miguel Ruiz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't see any problem right now. Users who already set postgresPassword
shouldn't face any issue
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Signed-off-by: Miguel Ruiz <[email protected]>
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
can we please get this merged? |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Probably solved at #27095 |
Signed-off-by: Bitnami Containers <[email protected]>
Description of the change
Fixes an issue where env variable
POSTGRES_POSTGRES_PASSWORD
was not being whenglobal.posgresql.username
/posgresql.username
is set to a value different thanpostgres
.Although key
postgresql-password
is being automatically generated in the Secret, the password will never be set unless valueposgresql.postgresPassword
/global.posgresql.postgresPassword
.This PR makes it possible for users to use postgresql-ha chart where
postgres
user uses a random password.Possible drawbacks
I'm not sure if this behavior was intentional, to force users to provide a password for user
postgres
and avoid risks of users losing the root user password on restarts.Applicable issues
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm