Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql-ha] Fix issue where user password is not set when a different username is provided #24593

Closed
wants to merge 7 commits into from

Conversation

migruiz4
Copy link
Member

Description of the change

Fixes an issue where env variable POSTGRES_POSTGRES_PASSWORD was not being when global.posgresql.username/posgresql.username is set to a value different than postgres.

Although key postgresql-password is being automatically generated in the Secret, the password will never be set unless value posgresql.postgresPassword/global.posgresql.postgresPassword.

This PR makes it possible for users to use postgresql-ha chart where postgres user uses a random password.

Possible drawbacks

I'm not sure if this behavior was intentional, to force users to provide a password for user postgres and avoid risks of users losing the root user password on restarts.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

… a different username is provided

Signed-off-by: Miguel Ruiz <[email protected]>
fmulero
fmulero previously approved these changes Mar 25, 2024
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't see any problem right now. Users who already set postgresPassword shouldn't face any issue

@carrodher carrodher changed the title [bitnami/postgresql-ha] Fix issue where user password is not set whe… [bitnami/postgresql-ha] Fix issue where user password is not set when a different username is provided Apr 4, 2024
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Apr 20, 2024
fmulero
fmulero previously approved these changes Apr 24, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@carrodher carrodher removed stale 15 days without activity solved labels May 1, 2024
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
fmulero
fmulero previously approved these changes May 13, 2024
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@8ball030
Copy link

can we please get this merged?
Theres like 3 issues which seem to be a subsequent downstream issue of this.

Copy link

github-actions bot commented Jun 4, 2024

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Jun 4, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@carrodher carrodher removed the stale 15 days without activity label Jun 14, 2024
@carrodher carrodher removed the solved label Jun 14, 2024
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher
Copy link
Member

Probably solved at #27095

Signed-off-by: Bitnami Containers <[email protected]>
@migruiz4 migruiz4 closed this Jun 19, 2024
@carrodher carrodher deleted the fix-postgres-password branch July 1, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami postgresql-ha solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql-ha] Standard postgresql-ha deployment fails when username/password are provided
5 participants