Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] Redict Support for Redis Chart #25164

Open
gmemstr opened this issue Apr 13, 2024 · 16 comments
Open

[bitnami/redis] Redict Support for Redis Chart #25164

gmemstr opened this issue Apr 13, 2024 · 16 comments
Assignees
Labels
feature-request on-hold Issues or Pull Requests with this label will never be considered stale redis

Comments

@gmemstr
Copy link

gmemstr commented Apr 13, 2024

Name and Version

bitnami/redis 19.1.0

What is the problem this feature will solve?

Redis is no longer free software and many are looking to adopt forks, including Redict. Redict has taken the stance that Redis is more or less complete software, and will continue maintenence relatively unchanged. This means that going forward, there is a FOSS option for for Redis chart to use. Redict has changed the binary name to redict-*, which will require tweaks from the chart.

What is the feature you are proposing to solve the problem?

Test and support either the upstream Redict image (https://codeberg.org/redict/-/packages/container/redict/7.3.0-bookworm) or build a custom image for the Helm chart.

What alternatives have you considered?

No response

@github-actions github-actions bot added the triage Triage is needed label Apr 13, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the feature request. I will forward this to the team for evaluation.

@javsalgar javsalgar added on-hold Issues or Pull Requests with this label will never be considered stale redis labels Apr 15, 2024
@javsalgar javsalgar changed the title Redict Support for Redis Chart [bitnami/redis] Redict Support for Redis Chart Apr 15, 2024
@github-actions github-actions bot removed the triage Triage is needed label Apr 15, 2024
@mickenordin
Copy link

Any updates on this? It would be very useful to have a full redis compatible dropin replacement, and redict seems to fit that bill best.

@carrodher
Copy link
Member

We're working on adding Valkey to the catalog

@gmemstr
Copy link
Author

gmemstr commented May 3, 2024

Redict recently added compatibility images, which should be drop-in replacements for Redis images in this chart https://codeberg.org/redict/redict-containers/commit/91b0b245ce721a4cc5765417b646d97452a24d33 so I consider this complete to some degree :)

@AmitKatyal-Sophos
Copy link

AmitKatyal-Sophos commented May 6, 2024

@carrodher Are we planning to add separate helm charts for valkey deployment as an alternative to redis helm chart ?

@javsalgar
Copy link
Contributor

Hi!

Yes, creating a helm chart for Valkey is in our roadmap

@AmitKatyal-Sophos
Copy link

@javsalgar Thanks for the update !
if we are already using redis helm charts with master-replica with sentinel configuration, the migration to valkey charts will be seamless ?

@carrodher
Copy link
Member

That's a good question for the Valkey community, we highly recommend that you refer to the forums and user guides provided by the project responsible for the application itself since there you can find proper guidance about migration from Redis to Valkey.

@mickenordin
Copy link

It should be possible to just use the redict compatibility images with the redis-charts now:

https://redict.io/docs/install/containers/#compatibility

https://artifacthub.io/packages/helm/bitnami/redis#use-a-different-redis-version

@AmitKatyal-Sophos
Copy link

@mickenordin we have redict images for redis server only or the same container has redis-sentinel binary as well ?.
As per documentation, only scratch container has redis-sentinel binary. How about other variants (debian, alpine...etc)

@mickenordin
Copy link

mickenordin commented May 7, 2024

@mickenordin we have redict images for redis server only or the same container has redis-sentinel binary as well ?. As per documentation, only scratch container has redis-sentinel binary. How about other variants (debian, alpine...etc)

All of them have all the binaries. So if that is not clear, the docs should probably be updated. Can you point me to the doc that gave you the impression it was not there? Edit: I see it now. Docs are being updated to be more clear now: https://codeberg.org/redict/redict.io/pulls/28

@AmitKatyal-Sophos
Copy link

@mickenordin Any specific reason that redict container images are not uploaded to the docker hub ?

@mickenordin
Copy link

mickenordin commented May 8, 2024

@mickenordin Any specific reason that redict container images are not uploaded to the docker hub ?

Yes, we discussed that and since people have to change their charts/configuration anyway, we prefer to run our own infrastructure, since it is something we know how to do and it will not add any additional inconvenience to people to just update the image to the full path registry.redict.io/redict.

@AmitKatyal-Sophos
Copy link

@mickenordin Any specific reason that redict container images are not uploaded to the docker hub ?

Yes, we discussed that and since people have to change their charts/configuration anyway, we prefer to run our own infrastructure, since it is something we know how to do and it will not add any additional inconvenience to people to just update the image to the full path registry.redict.io/redict.

we have a use-case of caching the image in our own hosted artifactory to avoid hitting public registry rate limiting, and unfortunately artifactory is only integrated with docker hub.

@mickenordin
Copy link

I think you can add any compliant docker registry to artefactory: https://medium.com/@andrenit/docker-and-artifactory-as-a-registry-mirror-1365891b39c5

@carrodher
Copy link
Member

carrodher commented May 8, 2024

We just released the Valkey container images, see the images in DockerHub

as well as the source code in GitHub (bitnami/valkey and bitnami/valkey-sentinel)

Any feedback is more than welcome, you can report any issue or suggestion at https://github.com/bitnami/containers/issues/new/choose

Now it's time for the Helm chart which is being developed at #25643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request on-hold Issues or Pull Requests with this label will never be considered stale redis
Projects
None yet
Development

No branches or pull requests

5 participants