[bitnami/redis-cluster] Possibility to add labels to redis-cluster pvc #25901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ammirator <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
|
Hey @rafariossaa @carrodher @javsalgar |
|
@javsalgar @rafariossaa @carrodher |
rafariossaa
previously approved these changes
May 20, 2024
Signed-off-by: Rafael Ríos Saavedra <[email protected]>
rafariossaa
approved these changes
May 20, 2024
|
@rafariossaa |
|
The new version is already published in DockerHub, see https://hub.docker.com/r/bitnamicharts/redis-cluster/tags. About the workflow, here you can find some info. |
fmulero
pushed a commit
to fmulero/charts
that referenced
this pull request
May 22, 2024
bitnami#25901) * Possibility to add labels to redis-cluster pvc Signed-off-by: Ammirator <[email protected]> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Ammirator <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Rafael Ríos Saavedra <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Rafael Ríos Saavedra <[email protected]> Signed-off-by: Fran Mulero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds "labels" field on PVC level
Benefits
It will allow us to add labels directly in helm chart values to PVC and not run manually separate scripts to add labels on PVC
A use case we have is that we use Longhorn as storage manager and to include a PVC in backup we need a label on it, and we want to have this on the helm chart values and not add manually with kubectl comamnd
Possible drawbacks
No, drawbacks is a minor change, is compatible with any version of this chart
Applicable issues
Additional information
Just a labels field on the created PVC, should be a easy merge
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm