[bitnami/nats] Add PersistentVolumeRetentionPolicy
#29371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robbie Blaine <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
juan131
requested changes
Sep 12, 2024
Co-authored-by: Juan Ariza Toledano <[email protected]> Signed-off-by: Robbie Blaine <[email protected]>
Signed-off-by: Robbie Blaine <[email protected]>
|
Thank you very much @juan131 for the quick review! 🎉 |
rblaine95
added a commit
to rblaine95/bitnami-charts
that referenced
this pull request
Sep 12, 2024
I accidentally committed it in bitnami#29371. Signed-off-by: Robbie Blaine <[email protected]>
1 task
migruiz4
pushed a commit
that referenced
this pull request
Sep 13, 2024
I accidentally committed it in #29371. Signed-off-by: Robbie Blaine <[email protected]>
bartramakers
pushed a commit
to bartramakers/bitnami-charts
that referenced
this pull request
Sep 18, 2024
bartramakers
pushed a commit
to bartramakers/bitnami-charts
that referenced
this pull request
Sep 18, 2024
I accidentally committed it in bitnami#29371. Signed-off-by: Robbie Blaine <[email protected]>
mike12806
pushed a commit
to mike12806/charts
that referenced
this pull request
Oct 30, 2024
Signed-off-by: Michael Faherty <[email protected]>
mike12806
pushed a commit
to mike12806/charts
that referenced
this pull request
Oct 30, 2024
I accidentally committed it in bitnami#29371. Signed-off-by: Robbie Blaine <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Added the
PersistentVolumeRetentionPolicyto the NATS Statefulset so that PVCs can be configured to automatically be cleaned up when scaling or deleting the NATS Statefulset.Disabled and set to Retain by default.
Benefits
PVCs can be configured to automatically be deleted (retained by default) when scaling or deleting the statefulset.
Possible drawbacks
None, disabled by default as in other charts (
bitnami/redis,bitnami/postgresql, for example)Applicable issues
None
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm