Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] json schema too strict for any template-able value #29451

Open
piccit opened this issue Sep 16, 2024 · 5 comments
Open

[bitnami/redis] json schema too strict for any template-able value #29451

piccit opened this issue Sep 16, 2024 · 5 comments
Assignees
Labels
in-progress redis tech-issues The user has a technical issue about an application

Comments

@piccit
Copy link

piccit commented Sep 16, 2024

Name and Version

bitnami/redis 20.0.4

What architecture are you using?

None

What steps will reproduce the bug?

  1. Set .Values.commonLabels to a string (containing Helm templating, for example)
  2. Run helm template .
  3. Observe error due to JSON schema validation

Are you using any custom parameters or values?

commonLabels: |
  app: {{ include "common.names.name" $ }}
  {{- with .Chart.AppVersion }}
  version: {{ . | quote }}
  {{- end -}}

What is the expected behavior?

Strings should be allowed as this value is passed to common.tplvalues.render

What do you see instead?

Error: values don't meet the specifications of the schema(s) in the following chart(s):
redis:
- commonLabels: Invalid type. Expected: object, given: string

Additional information

Per related issue #27319 and PR #27441, values that are templated should either be removed from the schema or correctly allow both objects and strings

@piccit piccit added the tech-issues The user has a technical issue about an application label Sep 16, 2024
@github-actions github-actions bot added the triage Triage is needed label Sep 16, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the request. As it is not a critical feature, we cannot guarantee an ETA, but if you want to speed up the process, you can submit a PR updating the json schema just like the PR you referenced.

Copy link

github-actions bot commented Oct 3, 2024

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Oct 3, 2024
Copy link

github-actions bot commented Oct 8, 2024

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@piccit
Copy link
Author

piccit commented Nov 19, 2024

Fixing with #30526

@piccit
Copy link
Author

piccit commented Dec 4, 2024

@javsalgar I'm not seeing a way to re-open this myself, but could you re-open this issue? The fix PR was erroneously closed and this issue is still an issue

@javsalgar javsalgar reopened this Dec 4, 2024
@bitnami-bot bitnami-bot removed the solved label Dec 4, 2024
@javsalgar javsalgar removed their assignment Dec 4, 2024
@github-actions github-actions bot removed the stale 15 days without activity label Dec 5, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 5, 2024
@github-actions github-actions bot assigned gongomgra and unassigned carrodher Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress redis tech-issues The user has a technical issue about an application
Projects
None yet
5 participants