Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/pgbouncer] Escape username and password for pgbouncer auth file generation. #46916

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[bitnami/pgbouncer] Escape username and password for pgbouncer auth file generation. #46916

merged 1 commit into from
Sep 12, 2023

Conversation

schwebke
Copy link
Contributor

@schwebke schwebke commented Sep 1, 2023 •
edited
Loading

Description of the change

Escape raw username and password following http://www.pgbouncer.org/config.html#authentication-file-format

Benefits

Bug fix.

Possible drawbacks

A workaround for #46094 is escaping quotes in the configuration.
This workaround has to be removed using the bugfix.

Applicable issues

#46094

Additional information

@github-actions github-actions bot added the triage Triage is needed label Sep 1, 2023
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. Just a friendly reminder that it's important to sign your commits. Adding your signature certifies that you either authored the patch or have the necessary rights to contribute the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@schwebke schwebke changed the title Escape username and password for pgbouncer auth file generation. [bitname/pgbouncer] Escape username and password for pgbouncer auth file generation. Sep 3, 2023
@schwebke schwebke changed the title [bitname/pgbouncer] Escape username and password for pgbouncer auth file generation. [bitnami/pgbouncer] Escape username and password for pgbouncer auth file generation. Sep 3, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Sep 4, 2023
@carrodher carrodher added the verify Execute verification workflow for these changes label Sep 4, 2023
@carrodher carrodher requested a review from Mauraza September 4, 2023 12:05
@carrodher carrodher assigned Mauraza and unassigned javsalgar Sep 4, 2023
@carrodher carrodher removed the request for review from javsalgar September 4, 2023 12:06
Mauraza
Mauraza approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@Mauraza Mauraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @schwebke,

Thanks for the contribution!! LGTM!!
This change will be available in the next revision of the container.

@Mauraza Mauraza merged commit d384b3e into bitnami:main Sep 12, 2023
12 checks passed
@CeliaGMqrz CeliaGMqrz mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mauraza Mauraza Mauraza approved these changes

Assignees

@Mauraza Mauraza

Labels
pgbouncer solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schwebke @carrodher @Mauraza @javsalgar