-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/elasticsearch] Fix readiness/liveness probe not working if "restEncryption: false" in values.yaml #47319
Conversation
Thanks for your contribution, please note in order for the CI/CD automation to work properly, it is needed to create a single PR per container. Could you please keep in this one only the changes related to ElasticSearch (per the title) creating a different PR for OpenSearch? Thanks |
…restEncryption: false" in values.yaml Signed-off-by: Andrea Rabbaglietti <[email protected]>
85e64d5
to
8aac178
Compare
Settled down the current PR and created another for Opensearch: #47340 Hope I've done right this time, sorry for the inconvenience :) |
@dgomezleon any chance you could accept this PR also? It's the same as #47340 (comment) but for Elasticsearch :) thank you so much! |
Hello guys :) If you would merge this too it would be great, thank you so much and keep it up with your fantastic work! Thank you so much bitnami guys 🥇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change
The readiness and liveness probes should work correctly regardless of the "restEncryption" setting. When "restEncryption" is set to "false," Elasticsearch should still be responsive to these probes, indicating its green health status.
Benefits
This fix the failing health-check (that is preventing Elasticsearch startup if security is on and tlsEncryption is off).
Without the fix, the health-check is failing because misses the basic-auth
Possible drawbacks
Nothing
Applicable issues
Additional information