Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/elasticsearch] Fix readiness/liveness probe not working if "restEncryption: false" in values.yaml #47319

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

rabbagliettiandrea
Copy link
Contributor

@rabbagliettiandrea rabbagliettiandrea commented Sep 4, 2023

Description of the change

The readiness and liveness probes should work correctly regardless of the "restEncryption" setting. When "restEncryption" is set to "false," Elasticsearch should still be responsive to these probes, indicating its green health status.

Benefits

This fix the failing health-check (that is preventing Elasticsearch startup if security is on and tlsEncryption is off).
Without the fix, the health-check is failing because misses the basic-auth

Possible drawbacks

Nothing

Applicable issues

Additional information

@github-actions github-actions bot added the triage Triage is needed label Sep 4, 2023
@carrodher carrodher changed the title [bitnami/elasticsearch] Fix readiness/liveness probe not working if "… [bitnami/elasticsearch] Fix readiness/liveness probe not working if "restEncryption: false" in values.yaml Sep 4, 2023
@carrodher
Copy link
Member

Thanks for your contribution, please note in order for the CI/CD automation to work properly, it is needed to create a single PR per container. Could you please keep in this one only the changes related to ElasticSearch (per the title) creating a different PR for OpenSearch? Thanks

…restEncryption: false" in values.yaml

Signed-off-by: Andrea Rabbaglietti <[email protected]>
@rabbagliettiandrea
Copy link
Contributor Author

Settled down the current PR and created another for Opensearch: #47340

Hope I've done right this time, sorry for the inconvenience :)

@carrodher carrodher added verify Execute verification workflow for these changes elasticsearch labels Sep 5, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Sep 5, 2023
@bitnami-bot bitnami-bot removed the request for review from carrodher September 5, 2023 06:42
@bitnami-bot bitnami-bot requested a review from corico44 September 5, 2023 06:42
@rabbagliettiandrea
Copy link
Contributor Author

@dgomezleon any chance you could accept this PR also? It's the same as #47340 (comment) but for Elasticsearch :) thank you so much!

@rabbagliettiandrea
Copy link
Contributor Author

Hello guys :)
this PR is the same as my other opened (and already merged!) for Opensearch: #47340

If you would merge this too it would be great, thank you so much and keep it up with your fantastic work!

Thank you so much bitnami guys 🥇

Copy link
Contributor

@corico44 corico44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corico44 corico44 merged commit 1291c97 into bitnami:main Sep 13, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elasticsearch solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/elasticsearch] readiness/liveness probe not working if "restEncryption: false" in values.yaml
3 participants