Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/airflow] Add missing LDAP environment variables #48236

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

fevisera
Copy link
Contributor

Description of the change

Trying to reproduce #48234 I came across some LDAP environment variables that are being missed.

$ docker-compose -f docker-compose-ldap.yml up -d
$ docker-compose -f docker-compose-ldap.yml logs -f airflow
airflow-airflow-1  | airflow 08:04:48.96 
airflow-airflow-1  | airflow 08:04:48.97 Welcome to the Bitnami airflow container
airflow-airflow-1  | airflow 08:04:48.97 Subscribe to project updates by watching https://github.com/bitnami/containers
airflow-airflow-1  | airflow 08:04:48.97 Submit issues and feature requests at https://github.com/bitnami/containers/issues
airflow-airflow-1  | airflow 08:04:48.97 
airflow-airflow-1  | airflow 08:04:48.98 INFO  ==> Enabling non-root system user with nss_wrapper
airflow-airflow-1  | airflow 08:04:49.00 INFO  ==> ** Starting Airflow setup **
airflow-airflow-1  | airflow 08:04:49.01 INFO  ==> Validating settings in POSTGRESQL_CLIENT_* env vars
airflow-airflow-1  | airflow 08:04:49.05 ERROR ==> Missing AIRFLOW_LDAP_ROLES_MAPPING
airflow-airflow-1  | airflow 08:04:49.05 ERROR ==> Missing AIRFLOW_LDAP_USER_REGISTRATION_ROLE

To prevent the occurrence of missing messages, we should include the following variables: AIRFLOW_LDAP_ROLES_MAPPING and AIRFLOW_LDAP_USER_REGISTRATION_ROLE.

Benefits

Users have a docker-compose-ldap.yml preconfigured with all the necessary environment variables.

Possible drawbacks

N/A

@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Sep 12, 2023
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fevisera fevisera merged commit d908b1b into main Sep 12, 2023
10 checks passed
@fevisera fevisera deleted the airflow-update-docker-compose-ldap branch September 12, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants