Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal Bitovi Angular Training 4-16-20 #194

Open
tehfedaykin opened this issue Apr 16, 2020 · 11 comments
Open

Internal Bitovi Angular Training 4-16-20 #194

tehfedaykin opened this issue Apr 16, 2020 · 11 comments
Assignees
@ishedu

Comments

@tehfedaykin
Copy link
Contributor

No description provided.

@chasenlehara
Copy link
Member

chasenlehara commented Apr 16, 2020 •
edited
Loading

Creating Components

  • es5BrowserSupport is not allowed in angular.json
  • update restaurant spec tests Type assertion using the '<>' syntax is forbidden. Use the 'as' syntax instead.
  • It’d be nice if the P2: How to Verify Your Solution is Correct section had code highlighting, so it’d be easier to know what changed from the generated file.

@chasenlehara
Copy link
Member

chasenlehara commented Apr 17, 2020 •
edited by ishedu
Loading

Adding Routing

  • The highlighting is off in at least these sections:
    • How to Verify Your Solution is Correct (off by one?)
    • Setting Paths to Components ({ path: '**', component: HomeComponent } should be highlighted too)

@tehfedaykin
Copy link
Contributor Author

tehfedaykin commented Apr 20, 2020 •
edited by ishedu
Loading

Use Restaurant API

  • Add bonus section to use async pipe
  • Fix value: [], //aray of restaurants

@tehfedaykin
Copy link
Contributor Author

tehfedaykin commented Apr 20, 2020 •
edited
Loading

City & State Options

  • In technical requirements call out iterating through cities and states for select options
  • Update tests in case option select values aren't set properly
  • Clean up optional state syntax in template

@chasenlehara
Copy link
Member

chasenlehara commented Apr 27, 2020 •
edited by ishedu
Loading

Filter Cities by State

  • FIx [RxJS RxJS guide] link

@chasenlehara
Copy link
Member

chasenlehara commented Apr 28, 2020 •
edited by ishedu
Loading

Optional: Declarative State

  • Fix shareReplay links

@chasenlehara
Copy link
Member

chasenlehara commented Apr 29, 2020 •
edited by ishedu
Loading

Nested Restaurant Routes

  • “Create a new component called details” should probably be detail
  • I think the code we had in src/app/app-routing.module.ts was fairly different from what is included in the solution on this page; namely, the routes are in reverse order

@chasenlehara
Copy link
Member

chasenlehara commented Apr 30, 2020 •
edited by ishedu
Loading

Building the Order Form

  • P2: What You Need to Know shows using Validators.required but _ P2: Solution_ does not use it
  • I think src/app/order/menu-items.component.ts should be src/app/order/menu-items/menu-items.component.ts

@chasenlehara
Copy link
Member

chasenlehara commented May 4, 2020 •
edited by ishedu
Loading

Order Service

  • Rewrite this so it makes sense: Create an order when the user submits a service.

@chasenlehara
Copy link
Member

chasenlehara commented May 5, 2020 •
edited by ishedu
Loading

Order History Component

  • src/app/order/history.component.html should be src/app/order/history/history.component.html
  • src/app/order/history.component.ts should be src/app/order/history/history.component.ts
  • P3: Solution is incorrect (no isPending) and the highlighting is off

@tehfedaykin
Copy link
Contributor Author

tehfedaykin commented May 5, 2020 •
edited by ishedu
Loading

Everywhere

  • update to use Angular's currency pipe
  • create and use ItemTotal pipe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishedu ishedu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tehfedaykin @ishedu @chasenlehara