Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI installed with brew throws punycode module deprecated warning message #11382

Closed
1 task done
kennycontreras opened this issue Oct 3, 2024 · 6 comments
Closed
1 task done
Labels
bug cli CLI Application

Comments

@kennycontreras
Copy link

Steps To Reproduce

bitwarden-cli (latest version) installed with brew throws a warning message
punycode module deprecated message

Expected Result

No warning message.

Actual Result

  1. After running any bw command through the terminal, a warning message with punycode module deprecated message appears.
  2. I found this MR that it was closed, but still, I just installed the CLI client today and I had the same warning message
  3. I fixed with the workaround of adding export NODE_OPTIONS="--no-deprecation" to my .zshrc

Screenshots or Videos

No response

Additional Context

No response

Operating System

macOS

Operating System Version

Sonoma 14.3

Shell

Zsh

Build Version

2024.9.0

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@kennycontreras kennycontreras added bug cli CLI Application labels Oct 3, 2024
@kennycontreras kennycontreras changed the title CLI installed with brew shows punycode module deprecated message CLI installed with brew throws punycode module deprecated message Oct 3, 2024
@kennycontreras kennycontreras changed the title CLI installed with brew throws punycode module deprecated message CLI installed with brew throws punycode module deprecated warning message Oct 3, 2024
@andrew-chang-dewitt
Copy link

andrew-chang-dewitt commented Oct 3, 2024

This is a known issue (not just w/ mac installs either), see #6689.

TL;DR: bw depends on jsdom, jsdom depends on punycode & bw has no control over that dependency rn. Looks like jsdom has a tracking issue on this dependency deprecation here: jsdom/jsdom#3613

@djsmith85
Copy link
Contributor

Duplicate of #6689

@djsmith85 djsmith85 marked this as a duplicate of #6689 Oct 3, 2024
@djsmith85
Copy link
Contributor

Hi @kennycontreras and @andrew-chang-dewitt

This is indeed a upstream issue with jsdom. jsdom has included the needed version bump of their dependency causing this and it got included with #10742. Merging it closed #6689.

The changes will be included in an upcoming release of the CLI.

Closing this now.

@djsmith85 djsmith85 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2024
@jessebot
Copy link

Do we know when that CLI release is expected?

@jeroenhabets
Copy link

Let's hope a CLI release is imminent...

Thanks again @djsmith85 🥇 !

@djsmith85
Copy link
Contributor

@jessebot, @jeroenhabets The CLI including the changes from #10742 did get released, but unfortunately there's another upstream dependency (node-fetch) that causes the same behaviour. The issue isn't fully resolved and being tracked with #6689 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli CLI Application
Projects
None yet
Development

No branches or pull requests

5 participants