code review fixes #3136
Annotations
2 errors and 10 warnings
test:
spec/features/lieutenant/filtering_spec.rb#L25
As Lieutenant I want to filter applications filters by activity
Failure/Error: expect(page).to have_selector(".applications-table tbody tr", count: n)
expected to find visible css ".applications-table tbody tr" 1 time, found 4 matches: "Bit Zesty Eligible by admin N1 9PF Arts and Media\nDisability\nView", "Bit Zesty Eligible by admin N1 9PF Sport\nDisability\nView", "Bit Zesty Eligible by admin N1 9PF Sport\nDisability\nView", "Bit Zesty Eligible by admin N1 9PF Sport\nDisability\nView"
|
test
Process completed with exit code 1.
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/setup-node@v2-beta. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2, actions/setup-node@v2-beta. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
test:
spec/controllers/assessor/reports_controller_spec.rb#L12
Assessor::ReportsController GET index
Failure/Error:
it "should render template" do
get :index
expect(response).to render_template("index")
end
`it` is not available from within an example (e.g. an `it` block) or from constructs that run in the scope of an example (e.g. `before`, `let`, etc). It is only available on an example group (e.g. a `describe` or `context` block).
|
test:
spec/controllers/assessor/reports_controller_spec.rb#L19
Assessor::ReportsController GET show
Failure/Error:
it "renders the show template" do
get :show, params: { id: 'feedbacks', category: 'trade' }, :format => 'pdf'
expect(response.content_type).to eq('application/pdf')
get :show, params: { id: 'case_summaries',category: 'trade' }, :format => 'csv'
expect(response.content_type).to eq('text/csv')
end
`it` is not available from within an example (e.g. an `it` block) or from constructs that run in the scope of an example (e.g. `before`, `let`, etc). It is only available on an example group (e.g. a `describe` or `context` block).
|
test:
spec/features/assessor/fulfills_the_draft_notes_spec.rb#L16
Assessor fulfills the draft notes. fulfills the draft notes form
Failure/Error: @form_answer ||= current_assessor.applications_scope(@award_year).includes(:assessor_assignments).find(params[:id]).decorate
ActiveRecord::RecordNotFound:
Couldn't find FormAnswer with 'id'=1 [WHERE "form_answers"."award_year_id" = $1 AND "form_answers"."state" IN ($2, $3, $4, $5, $6, $7, $8) AND "form_answers"."sub_group" = $9]
|
test:
spec/validators/advanced_email_validator_spec.rb#L49
AdvancedEmailValidator allows correct e-mail addresses
|
test:
spec/validators/advanced_email_validator_spec.rb#L61
AdvancedEmailValidator DNS checks for domain checks for the existence of an MX record for the domain
|
test:
spec/validators/advanced_email_validator_spec.rb#L70
AdvancedEmailValidator DNS checks for domain doesn't return an error when the MX lookup timed out
|
test:
spec/validators/advanced_email_validator_spec.rb#L95
AdvancedEmailValidator bounced addresses prevents validation on an e-mail address marked as bounced in sendgrid
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|