patch: fix rasterio 1.4.x regression #1132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This pull-request addresses a regression in the behaviour of the recently released
rasterio
1.4.0 (and 1.4.1 patch).For further details see rasterio/rasterio#3191.
Essentially
geovista
now explicitly manages the shape of data passed in and out of the rasterio.transform.xy function.There was an implicit user assumption that
rasterio
would maintain the shape of data passed throughrasterio.transform.xy
, and this assumption held prior to 1.4.0.rasterio
1.4.0 then enforced its expectation that data passed torasterio.transform.xy
was only 1-D.The
rasterio
1.4.1 patch reverted this regression in behaviour, thus allowing (forgeovista
) 2-D data to be passed intorasterio.transform.xy
again. However, the resultant transformed data was no longer 2-D. This subsequently caused an issue for thegeovista.bridge
.Rather than pin or wait for
rasterio
to possibly patch again, we now control the shape of the data ourselves.Closes #1131