Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: fix rasterio 1.4.x regression #1132

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Oct 2, 2024

🚀 Pull Request

Description

This pull-request addresses a regression in the behaviour of the recently released rasterio 1.4.0 (and 1.4.1 patch).

For further details see rasterio/rasterio#3191.

Essentially geovista now explicitly manages the shape of data passed in and out of the rasterio.transform.xy function.

There was an implicit user assumption that rasterio would maintain the shape of data passed through rasterio.transform.xy, and this assumption held prior to 1.4.0.

rasterio 1.4.0 then enforced its expectation that data passed to rasterio.transform.xy was only 1-D.

The rasterio 1.4.1 patch reverted this regression in behaviour, thus allowing (for geovista) 2-D data to be passed into rasterio.transform.xy again. However, the resultant transformed data was no longer 2-D. This subsequently caused an issue for the geovista.bridge.

Rather than pin or wait for rasterio to possibly patch again, we now control the shape of the data ourselves.

Closes #1131


@bjlittle bjlittle added the type: bug Auto-labelled for bug/*, fix/* and patch/* branches label Oct 2, 2024
@github-actions github-actions bot added the type: testing Auto-labelled label Oct 2, 2024
@github-actions github-actions bot added the type: examples Auto-labelled for ex/*, example/* and examples/* branches label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (57fc7ed) to head (22841f1).
Report is 1 commits behind head on v0.5.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           v0.5.x    #1132      +/-   ##
==========================================
+ Coverage   91.30%   91.32%   +0.01%     
==========================================
  Files          58       58              
  Lines        2934     2939       +5     
==========================================
+ Hits         2679     2684       +5     
  Misses        255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle merged commit 8cc8d69 into v0.5.x Oct 3, 2024
21 checks passed
@bjlittle bjlittle deleted the rasterio-regression-fix branch October 3, 2024 11:13
bjlittle added a commit that referenced this pull request Oct 3, 2024
* patch: fix gridline tests for np 2.x (#998)

* patch: fix rasterio 1.4.x regression (#1132)

* patch: fix rasterio 1.4.x regression

* remove broken link (#1065)

* fix upload coverage (#1075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Auto-labelled for bug/*, fix/* and patch/* branches type: examples Auto-labelled for ex/*, example/* and examples/* branches type: testing Auto-labelled
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

1 participant