Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-changelog get pr number #1155

Merged
merged 2 commits into from
Oct 15, 2024
Merged

ci-changelog get pr number #1155

merged 2 commits into from
Oct 15, 2024

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Oct 15, 2024

🚀 Pull Request

Description

This pull-request reverts the use of the jwalton/gh-find-current-pr GHA within the ci-changelog as it was not working for a pull-request sourced from a forked geovista repository (reference #1152).

There are various other GHAs that purport to do this, but sadly this doesn't seem to be the case after experimentation.

Given that the ci-changelog GHA will only be expected to execute based on a pull_request event and not a push, we should be able to simply use github.event.number or github.event.pull_request.number instead.

Let's give it a whirl ...


@github-actions github-actions bot added the type: gha Auto-labelled label Oct 15, 2024
@bjlittle bjlittle force-pushed the ci-changelog-get-pr branch from ec4b534 to 42cd826 Compare October 15, 2024 21:51
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (00afb5e) to head (65acc8b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1155   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          58       58           
  Lines        2939     2939           
=======================================
  Hits         2683     2683           
  Misses        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle enabled auto-merge (squash) October 15, 2024 22:06
@bjlittle bjlittle merged commit 9df7aed into main Oct 15, 2024
22 checks passed
@bjlittle bjlittle deleted the ci-changelog-get-pr branch October 15, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: gha Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant