Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pooch fetch user-agent header #1202

Merged
merged 4 commits into from
Nov 15, 2024
Merged

add pooch fetch user-agent header #1202

merged 4 commits into from
Nov 15, 2024

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Nov 15, 2024

🚀 Pull Request

Description

This pull-request injects a User-Agent into the headers of a requests.get issued by pooch.Pooch.fetch when requesting to download an asset.

This is to avoid potential HTTP 403 Forbidden responses from GitHub i.e., RTD servers have unfortunately started to experience this issue for several projects building their documentation.

For further details see readthedocs/readthedocs.org#11763.


@github-actions github-actions bot added type: infrastructure Auto-labelled type: testing Auto-labelled labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.33%. Comparing base (36ea0db) to head (a9cd38b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/geovista/cache/__init__.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
+ Coverage   91.32%   91.33%   +0.01%     
==========================================
  Files          58       58              
  Lines        2939     2956      +17     
==========================================
+ Hits         2684     2700      +16     
- Misses        255      256       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the type: documentation Auto-labelled for doc/* and docs/* branches label Nov 15, 2024
@bjlittle bjlittle merged commit f504e55 into main Nov 15, 2024
21 of 22 checks passed
@bjlittle bjlittle deleted the pooch-requests-user-agent branch November 15, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Auto-labelled for doc/* and docs/* branches type: infrastructure Auto-labelled type: testing Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant