Add taplo pre-commit hook to format and sort toml files
#1207
+173
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 58 58
Lines 2956 2956
=======================================
Hits 2700 2700
Misses 256 256 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
bjlittle
approved these changes
Nov 18, 2024
bjlittle
force-pushed
the
maint/pre-commit-toml-sort
branch
from
ceb8d18 to
fcb8e79
Compare
bjlittle
requested changes
Nov 18, 2024
There was a problem hiding this comment.
@tkoyama010 You need to add a changelog news fragment, see here.
I'd suggest its type is a contributor change 👍
bjlittle
force-pushed
the
maint/pre-commit-toml-sort
branch
from
fcb8e79 to
d2adcb2
Compare
bjlittle
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
@tkoyama010 Awesome effort, thanks! 🏆
Keen to get this banked before it goes stale 👍
|
@tkoyama010 I'll merge this PR before #1211 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
resolve #1205