Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fastparquet and pandas examples package #460

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Add fastparquet and pandas examples package #460

merged 6 commits into from
Sep 25, 2023

Conversation

tkoyama010
Copy link
Collaborator

🚀 Pull Request

Description

This PR adds the pandas package to support test image run.


@github-actions github-actions bot added the type: dependencies Auto-labelled label Sep 25, 2023
@tkoyama010 tkoyama010 requested a review from bjlittle September 25, 2023 21:15
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #460 (dcea2f9) into main (c0e16c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files          66       66           
  Lines        3617     3617           
=======================================
  Hits         3119     3119           
  Misses        498      498           

@tkoyama010 tkoyama010 changed the title Add pandas test package Add fastparquet and pandas examples package Sep 25, 2023
@tkoyama010 tkoyama010 requested a review from bjlittle September 25, 2023 22:01
@tkoyama010 tkoyama010 changed the title Add fastparquet and pandas examples package Add fastparquet and pandas examples package Sep 25, 2023
Copy link
Owner

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkoyama010 Brilliant, thanks! 🤩

You just need to add the entry to the pyproject.toml then we're good to go! 🚀

@tkoyama010 tkoyama010 requested a review from bjlittle September 25, 2023 22:09
@bjlittle
Copy link
Owner

@tkoyama010 When this is merged, I'll re-render the conda lockfiles so that you can then rebase #450 to get the pandas and fastparquet dependencies in the GHA CI 👍

@tkoyama010 tkoyama010 merged commit 23d50da into main Sep 25, 2023
15 checks passed
@tkoyama010 tkoyama010 deleted the add-pandas branch September 25, 2023 22:15
@bjlittle
Copy link
Owner

@all-contributors please add @tkoyama010 for infra

Copy link
Contributor

@bjlittle

I've updated the pull request to add @tkoyama010! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependencies Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants