vs2017 Project Configured with SDK 8.1

[christianbrugger]

When I create a project for vs2017 with the following command:

..\bx\tools\bin\windows\genie --with-examples vs2017

And then open the project with vs2017, it is configured with the Windows SDK 8.1. The common SDK for vs2017 is 10.0. I got build errors at first, that the SDK could not be found on my system. And even after I installed the SKD 8.1 (from MS website, or via vs2017 installer), different includes could not be found, e.g. stdlib.h. All compiles after switching to SDK 10.0 in the project settings. And only after I installed vs2015 on my computer, I am able to use the SDK 8.1 in vs2017.

Would you adapt the build generator such that SDK 10.0 is configured by default in the vs2017 projects?

[bkaradzic]

There is already option for that (see GENie options in bgfx project):

 --with-windows=#  Set the Windows target platform version (default: $WindowsSDKVersion or 8.1).

But after installing VS default SDK value should be in WindowsSDKVersion environment variable, and then you don't have to specify it every time.

[Cleroth]

Nowadays the default should likely just be "10.0" which VS now uses to mean "latest SDK".

[bkaradzic]

@Cleroth Use VS2019, VS2022, it defaults to 10.0 there.

[Cleroth]

@bkaradzic I did try with VS2022, it still uses 8.1 with VS2022
I used
..\bx\tools\bin\windows\genie --with-examples --with-tools vs2022
Only worked properly with:
..\bx\tools\bin\windows\genie --with-examples --with-tools --with-windows=10.0 vs2022

[bkaradzic]

Code is here: https://github.com/bkaradzic/GENie/blob/0f5133b66d103efbcdf7c0d23f6cb6b353282e38/src/actions/vstudio/vs2022.lua#L60

You should figure out what's wrong with it and then send PR with the fix.