-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Printing api URL disturbs target application #34
Comments
Ok. Now I see there are already several merge requests for this bug. The least intrusive from jofusa. Can you merge that please? |
+1, please :) |
+1 |
2 similar comments
+1 |
+1 |
Hi I'm still having this issue with the latest pip install of pyrabbit (1.1.0). Everytime I use the client it prints the url, when I use "pip install -U git+https://github.com/bkjones/pyrabbit.git" it removes this issue but I then get; Traceback (most recent call last): This appear when trying to run a very basic code ? from pyrabbit.api import Client cl = Client('localhost:15672', 'guest', 'guest') any help would be greatly appreciated |
+1 This is fixed in master but not latest v1.1.0 release https://github.com/bkjones/pyrabbit/blob/v1.1.0/pyrabbit/http.py#L101 I'm redirecting stdout to /dev/null as a workaround |
+1 |
I fork and update module. Welcome https://github.com/deslum/pyrabbit2 |
Method
HTTPClient.do_call()
(http.py, line 101) unconditionally echoes url. I use pyrabbit in an agent which catches and parses stdout. Echoed url causes error since is unexpected by the agent.I see two possible solutions:
url
is a debug message and thus it shall be removed.url
printing is useful somehow. Then the client class shall have optionsilent=False
. If set to true, theurl
won't be echoed.The text was updated successfully, but these errors were encountered: