Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backgroundGrid
I wanted to add a background grid in my existing project that is using react-d3-grid and I found the easiest way is to modify the package itself.
implementation
I used svg
<pattern>
and and a background<rect fill="url(#grid-pattern)"/>
to implement the grid.usage
there's a new props in
<Tree />
when backgroundGrid is undefined, grid will not be rendered.
there's 2 default type of grid:
dot
andline
color
: color of each line / dotthickness
: thickness of each line / radius of the each dotgridCellSize
: the space take place by each dot / cross / customRenderFunctiontype: custom
allows customizing content inside bypassing
gridCellFunc
a function that return a ReactElement(svg elements)testing
I added unit testing for
<BackgroundGrid />
but haven't added testing for zooming, draggingscreenshots