Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: calculate the real mass by nodes #9

Open
Gordon-Dry opened this issue Jun 14, 2018 · 1 comment
Open

Enhancement: calculate the real mass by nodes #9

Gordon-Dry opened this issue Jun 14, 2018 · 1 comment

Comments

@Gordon-Dry
Copy link

Gordon-Dry commented Jun 14, 2018

A)

Instead of using the mass written to the config, do a real calculation:

  1. check if it has a node_stack_top and node_stack_bottom, then it is stackable
  2. if it's stackable just estimate it's round
  3. by using the node values y from node_stack_top and node_stack_bottom and the z value from node_attach it's possible to calculate the volume of the battery, it's just a cylinder
  4. find a decent mass/density value depending battery type
  5. calculate the mass
  6. write it back into the MM cache by a patch

If it's not stackable estimate that it's not round, make a 2/3 estimation of the size relative to the width and estimate that it is max. 40% the height than the width. Just guess.

Or even ignore non-stackable batteries in this process and estimate the devs have written a good value in the config as mass.

B)

Be bad and make it even possible that batteries have different types, not all of them are generally one of these types:
1 = Lead_Acid
2 = Lead_Acid_singleUse
3 = Li_Ion

The battery type to be switchable in VAB/SPH would be awesome.
No more set-it-in-config-and-load-KSP setup.

C)

Make it partUpgradable in career progress which kind of battery even is possible.
1 = Lead_Acid - early career, should get it quick
2 = Lead_Acid_singleUse - very early career, for starters
3 = Li_Ion - later you know, but not in the far future

This ofc depends the used tech tree - but just take CTT as reference.

D) Balance all out. Mass vs. EC vs. SC.

Actually, a stock GameData\Squad\Parts\Electrical\z-200Battery\z-200Battery.cfg has a weight of 10 kg defined in the config.
This battery is round, has a diameter of 62.5 cm and a height of 20cm.
10 kg is not enough. Batteries are dense and heavy.
(mobile phone batteries are just very flat and have a lot of plastic)

But consider this:
RealBattery actually makes a 10 kg battery have 200 EC and 20 SC.
20 SC are valid 72,000 EC.
So a total of 72,200 EC in a 10 kg battery.
Or more than 20 kW/h.

So, after doing A) - C) how much mass would the same battery have then?
And what is a realistic mass/density factor?
How much EC/SC could this (heavier) battery take? By old (now) calculation and by new (nerfed) calculation?

@Gordon-Dry
Copy link
Author

btw I always wondered why the amount of SC is a 1/10 of the amount of EC - when 1 SC is the equivalent of 3600 EC that means that the part got 360x the amount of EC converted to SC ... on top of the EC already in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant