Honor configure options better #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "prefix" more in line with standard unix/linux conventions and use the value provided by ./configure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a problem building from source and using a non-standard path. (Specifically, this was building on an HPC system without root/sudo.) The build would fail because the makefile was ignoring
$LDFLAGSfrom the environment and failing to findnloptandadolc.Additionally, the makefile was setting the install prefix staticly rather than accepting the value from
./configure --prefix=something.The proposed changes use the
prefixvalue provided by./configure(and use it more like standard unix/linux conventions) and also include the$LDFLAGSvalue from the environment.