Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch feature for Android and iOS #457

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Torch feature for Android and iOS #457

wants to merge 5 commits into from

Conversation

marqroldan
Copy link
Contributor

They don't seem to break on iOS 12 and Android 10, these are the only devices that I have at the moment.

@marqroldan
Copy link
Contributor Author

The Android implementation doesn't work if used with #452

Most likely affect devices that have multiple back-facing camera (I'm using SM-A715F)

Possibly because of the way the back camera is obtained (it loops until the last camera) + uses Camera1 API

@slycoder
Copy link
Collaborator

Given that #452 has been merged is it just a minor change to the camera capturer logic to get it to work?

I wonder if moving to camera2 will allow third parties to manipulate the torch without embedding it into this library? If so maybe the right solution is to bite the bullet and do that upgrade instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slycoder slycoder slycoder approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marqroldan @slycoder