-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to scala2.12 #8
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this.
I believe in one logical change per one commit, so can you split this up into multiple commits please. For example, all the whitespace formatting should be done in a separate commit.
@@ -1,4 +1,5 @@ | |||
import scalariform.formatter.preferences._ | |||
import com.typesafe.sbt.SbtScalariform.ScalariformKeys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra whitespace.
"2.11.0-M7") | ||
"2.11.0-M7", "2.12.8") | ||
|
||
// resolvers in Global ++= Seq( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't include commented out lines in general. What is the intention of this?
"-feature" :: "-language:implicitConversions" :: options2 | ||
} | ||
} | ||
// scalacOptions <++= scalaVersion map { v: String => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete commented out code.
setPreference(AlignParameters, true). | ||
setPreference(CompactControlReadability, true). | ||
setPreference(DoubleIndentClassDeclaration, true) | ||
ScalariformKeys.preferences := FormattingPreferences(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra whitespace.
No description provided.