Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Key bar not showing up #2056

Open
2 tasks done
unoctanium opened this issue Sep 28, 2024 · 3 comments
Open
2 tasks done

Smart Key bar not showing up #2056

unoctanium opened this issue Sep 28, 2024 · 3 comments

Comments

@unoctanium
Copy link

unoctanium commented Sep 28, 2024

Checklist

Configuration

Xcode: 16.0 (16A242d)
Blink: v18.0.0.927 (Test Flight). Sep 28 2024. branch: default (raw)
iPadOS Version: 18.0

Describe the bug

This is a brand new checkout, following the installation guide in the Build section of the README.md file.

The Smart Key bar is not showing up.
In Settings.app->General->Keyboard->Shortcuts-toggle, I tested with both - switch on or off
I don't use assistive touch

I built from GitHub repo and deployed in release mode to

  1. physical device: iPad Pro (11 inch) (4th generation), iPadOS 18.0
  2. Simulator: iPad Air 11 inch (M2), iOS 18.0

On my device I tested without and with hardware keyboarrd attached.
In the sim I tested without or with hardware keyboard setting.

Thus bug is only related to iPad. Smart key bar shows up on iPhone.

@unoctanium unoctanium added the bug Bug that's either related to Blink Shell or prevents the user to use the app in normal conditions. label Sep 28, 2024
@unoctanium
Copy link
Author

Following this workaround: #1898

In Blink/Smarter Keys/SmarterTermInput.swift
I changed line line 180 from

if KBTracker.shared.isHardwareKB {

to

if isHardwareKB {

Actually, I didn’t understand the logic behind this change but now, the Smart Key bar is always shown.

@unoctanium
Copy link
Author

but with this workaround the smart key bar looks scambled and is not usable when a physical keyboard is attached

@carloscabanero
Copy link
Member

This is a known issue with iOS and we have reported it multiple times. Won't dig deeper as the plan is to rewrite the SmartKeys bar and the Terminal itself.

@carloscabanero carloscabanero added won't fix and removed bug Bug that's either related to Blink Shell or prevents the user to use the app in normal conditions. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants