full / fullscreen display mode shows nothing

[guix77]

When using full & fullscreen display modes, no content is displayed. The displayHtml property is of course filled in. It's the same for LearningMachine's examples, for instance https://blockcerts.learningmachine.com/certificate/ab56912734bb5784bced00b7e0e82ac9?format=json

Using "@blockcerts/blockcerts-verifier": "^1.25.0". Any idea ?

[raiseandfall]

Hi @guix77
I'm not getting any error after a simple test (running the BV locally). Can you send us more details such as the browser you use, your implementation of the BV or any console errors ?
Thank you

[guix77]

Hi @raiseandfall and thanks for your answer !

I cloned this repo and tried BV's demos, they work so the browser is not the issue (chrome 77 on Ubuntu)

Here is a simple example that does not work: https://github.com/guix77/blockcerts-verifier-test

Getting lots of e.trim is not a function

[guix77]

Strange: if I use the IE11 compatibility:

<script src="node_modules/@webcomponents/webcomponentsjs/custom-elements-es5-adapter.js"></script>
<script src="node_modules/@webcomponents/webcomponentsjs/webcomponents-loader.js"></script>
<script src="node_modules/@blockcerts/blockcerts-verifier/dist/ie11.js"></script>

... then it works. Example https://github.com/guix77/blockcerts-verifier-test/tree/ie11

Even more strange: BV's demos, which work, are not in IE11 compatibility mode:

<script src="../node_modules/@webcomponents/webcomponentsjs/webcomponents-loader.js"></script>
<script type="module" src="../node_modules/@polymer/iron-demo-helpers/demo-pages-shared-styles.js"></script>
<script type="module" src="../node_modules/@polymer/iron-demo-helpers/demo-snippet.js"></script>
<script type="module" src="../src/blockcerts-verifier/index.js"></script>

Anyway, it works for me now... so that's a good thing :)

[lemoustachiste]

@raiseandfall I haven't looked deeper than that, but here is what I have found:

• blockcerts.org works, but is using v1.24 - it does not have the latest changes with the whitelist
• locally with the repro I have seen it fail
• the version used is v1.25 (with the whitelist changes)
• the issue seems to be with trim, and potentially a polyfill? Hence why it would work with the IE11 compat code?
• there has been some changes with the addition of terser, and some stylistic change in the output: 700a783#diff-87a7733351401476796693ae3d0985ccR1747. So maybe that's related?

[raiseandfall]

@guix77 @lemoustachiste
The terser plugin on the sanitizer file was indeed the problem. I removed it for now and opened a ticket to address it #223

The fix is in 1.25.1