Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "postinstall" script fails on Windows system #1486

Open
antonellopasella opened this issue Mar 20, 2023 · 4 comments
Open

The "postinstall" script fails on Windows system #1486

antonellopasella opened this issue Mar 20, 2023 · 4 comments

Comments

@antonellopasella
Copy link

When running the build on windows systems (also when building the verifier that depends on this package) nodejs fails due to the lack of "rm" command on windows

May we use nodejs packages like rimraf?

@lemoustachiste
Copy link
Member

Yes please go for it

I still hope to get to a point where we can get rid of that dirty postinstall script but third parties (deps of deps) are slow to accept updating

@SinuheCortes
Copy link

@antonellopasella ,I just stumbled with this issue, did you found a solution for this?

Thanks.

@antonellopasella
Copy link
Author

@SinuheCortes nope. I'm running it inside a docker container

@lemoustachiste
Copy link
Member

@SinuheCortes, @antonellopasella's proposed solution is the way to go, if you replace rm -rf in this line: https://github.com/blockchain-certificates/cert-verifier-js/blob/master/package.json#L14 by rimraf it will work cross platform.

I don't have just yet to deal with this but you can open a PR with a fix in your commit to trigger a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants