Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout / catch exception when we cannot obtain the issuer profile. #22

Open
raiseandfall opened this issue Apr 2, 2018 · 3 comments
Open

Add timeout / catch exception when we cannot obtain the issuer profile. #22

raiseandfall opened this issue Apr 2, 2018 · 3 comments
Assignees
@raiseandfall
Labels
enhancement

Comments

@raiseandfall
Copy link
Member

With a specific error message "Could not obtain issuer profile".
@raiseandfall raiseandfall self-assigned this Apr 2, 2018
@kimdhamilton
Copy link
Member

more broadly, we should timeout and catch when any lookup fails. The error message should reflect that

@lemoustachiste
Copy link
Member

@raiseandfall would that still be an issue? With the request method if there is an error it is caught and an error is thrown. However indeed we don't handle any timeouts.

@raiseandfall
Copy link
Member Author

@lemoustachiste True. Handling global timeouts might have to be a different ticket, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raiseandfall raiseandfall

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@raiseandfall @kimdhamilton @lemoustachiste