Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify why e2e test still require etherscan api key #592

Open
lemoustachiste opened this issue Jun 1, 2020 · 0 comments
Open

Identify why e2e test still require etherscan api key #592

lemoustachiste opened this issue Jun 1, 2020 · 0 comments

Comments

@lemoustachiste
Copy link
Member

while working on #549 I found that ethereum e2e tests require the API key for etherscan. However since we are supposedly caching API call results, this shouldn't be the case.
We should investigate if calls are actually made to the API during unit tests, and circumvent them if they are happening.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lemoustachiste