Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Issuing Estimates #15

Merged
merged 8 commits into from
Nov 17, 2017
Merged

Supports Issuing Estimates #15

merged 8 commits into from
Nov 17, 2017

Conversation

bedinotti
Copy link
Contributor

@bedinotti bedinotti commented Nov 17, 2017

This is a first pass at #11. A few notes on my implementation:

  • The issuingEstimateURL and issuingEstimateAuth properties are added on to the IssuerResponse object instead of the IssuerRecord. This is purely because IssuerRecord is backed up by the on-device SQL store, and I wasn't entirely sure I wanted to worry about testing a SQL migration in an upgrade. (It should be fine, since I'm just adding 2 more columns, but still...)
  • The outcome of that decision is that those values aren't stored on device. They don't persist. So a new request to the issuer is made each time you navigate to the Issuer screen. We'd have to make a network call anyway to get the estimate data, so this doesn't really add much load.
  • It does make this bit of code more complicated. The IssuerResponse has the auth estimate URL, but only the IssuerRecord has the public address submitted to this issuer. So we have to get both and combine them before we can ask for estimates.

@bedinotti
Copy link
Contributor Author

Oh, and this is what it looks like in the UI:
screenshot_1510941114

@bedinotti bedinotti merged commit b5d6d7e into master Nov 17, 2017
@bedinotti bedinotti deleted the downie-issuingEstimate branch November 17, 2017 20:50
bedinotti pushed a commit that referenced this pull request Dec 18, 2017
…suingEstimate"

This reverts commit b5d6d7e, reversing
changes made to b0916eb.
bedinotti pushed a commit that referenced this pull request Dec 18, 2017
…ownie-issuingEstimate""

This reverts commit 8af111e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant