Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at #11. A few notes on my implementation:
issuingEstimateURL
andissuingEstimateAuth
properties are added on to theIssuerResponse
object instead of theIssuerRecord
. This is purely becauseIssuerRecord
is backed up by the on-device SQL store, and I wasn't entirely sure I wanted to worry about testing a SQL migration in an upgrade. (It should be fine, since I'm just adding 2 more columns, but still...)IssuerResponse
has the auth estimate URL, but only theIssuerRecord
has the public address submitted to this issuer. So we have to get both and combine them before we can ask for estimates.