Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable WC social login #2140

Open
maikReal opened this issue Aug 5, 2024 · 4 comments · May be fixed by #2159
Open

Enable WC social login #2140

maikReal opened this issue Aug 5, 2024 · 4 comments · May be fixed by #2159
Assignees
@ulyanas
Labels
enhancement New feature or request need info Waiting for more information from issue author

Comments

@maikReal
Copy link
Collaborator

maikReal commented Aug 5, 2024 •
edited
Loading

What to do?

We need to enable the social login for the WalletConnect widget. But before enabling it, we need to check what will be the result of a wallet connection if a user is using "Sign in with Farcaster". As for the BS account v2 we need to have a wallet address and the signature to create a BS account, we need to have the same info if a user uses the social login

https://walletconnect.com/blog/sign-in-with-farcaster-appkit

https://secure.walletconnect.com/dashboard

For BS account V2:

  • WC creates an EOA address by social login, seems we need to request a window where a user can sign a message
@maikReal maikReal added the enhancement New feature or request label Aug 5, 2024
@maxaleks maxaleks linked a pull request Aug 9, 2024 that will close this issue
Draft
4 tasks
@maxaleks
Copy link
Contributor

maxaleks commented Aug 9, 2024

@maikReal @tom2drum
I tested this feature, but it doesn't seem to work. More details in the PR description: #2159

@maikReal
Copy link
Collaborator Author

@maxaleks Tested this feature once again. Works well for me. Let's merge it

@ulyanas
Copy link

ulyanas commented Oct 28, 2024

Reown (WC) doesn't seem to work on mobile, need to re-test and escalate to the Reown (WC) team if needed

@ulyanas ulyanas assigned tom2drum and ulyanas and unassigned tom2drum Oct 28, 2024
@NikitaSavik NikitaSavik added the need info Waiting for more information from issue author label Dec 2, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale For stale issues which don't have any recent activities label Dec 17, 2024
@tom2drum tom2drum removed the stale For stale issues which don't have any recent activities label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulyanas ulyanas

Labels
enhancement New feature or request need info Waiting for more information from issue author
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable WC social login blockscout/frontend
5 participants
@NikitaSavik @ulyanas @maxaleks @tom2drum @maikReal