Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

way to hide quests as well? #1

Open
JourneyOver opened this issue Sep 15, 2023 · 18 comments
Open

way to hide quests as well? #1

JourneyOver opened this issue Sep 15, 2023 · 18 comments

Comments

@JourneyOver
Copy link

Would love to see this be able to filter out quest icons as well and not just POI and vignette stuff. Mainly asking because there is a quest called "To Tame a Thunderspine" that if done on one character can't be done on an alt but the quest icon will always show up on the map regardless on any alts, and it gets pretty annoying seeing the quest icon for it everytime I am on an alt..

@bloerwald
Copy link
Owner

Try the new version. This is my Valdrakken after filtering the PvP weeklies:

image

Thanks for the reminder, wanted to add that as well.

@JourneyOver
Copy link
Author

JourneyOver commented Sep 16, 2023

So it doesn't seem to work at all on the quest I had mentioned in the OP for some reason ("To Tame a Thunderspine"), I even downloaded downloaded the idTip addon to see if there was some magical ID that was different to the one shown on wowhead by chance but mousing over the quest icon it sadly seems to not show an ID at all (there seems to be a couple quests that are like this)

I did test on the pvp quest "Sparks of Life: The Waking Shores" (currently one of the pvp quests up for this week) in Valdrakken to make sure things was working correctly and it does hide that quest so I'm not sure exactly what is going on with the quest "To Tame a Thunderspine"

edit: So it seems that if a quest icon does not have an ID attached to it, it does not allow the hiding of the icon at all, as I just did a test with another quest that doesn't seem to have an ID on the mouoseover tooltip for the quest and it did not hide that quest icon at all either. "https://www.wowhead.com/quest=76592/a-single-wing"


also just a random note: filter quests seem to work (except for what I mentioned above), but for some reason unfiltering quests does not work. Using the "Sparks of Life: The Waking Shores" as an example, after filtering the quest with /mc filterquest 72646 and that working, upon trying to unfilter the quest with /mc unfilterquest 72646 it never allows me to press enter, and everytime I do press enter I get an error message:

Interface/AddOns/MapCleaner/MapCleaner.lua:302: attempt to index global 'MAPCLEANER_FILTERED_QuestS' (a nil value)
Count: 64

Call Stack:
[string "=[C]"]: ?
[string "@Interface/AddOns/MapCleaner/MapCleaner.lua"]:302: in function `RemoveFilterForQuest'
[string "@Interface/AddOns/MapCleaner/MapCleaner.lua"]:399: in function `Cli'
[string "@Interface/AddOns/MapCleaner/MapCleaner.lua"]:419: in function `?'
[string "@Interface/FrameXML/ChatFrame.lua"]:5281: in function <Interface/FrameXML/ChatFrame.lua:5227>
[string "=[C]"]: in function `ChatEdit_ParseText'
[string "@Interface/FrameXML/ChatFrame.lua"]:4938: in function `ChatEdit_SendText'
[string "@Interface/FrameXML/ChatFrame.lua"]:4974: in function `ChatEdit_OnEnterPressed'
[string "*ChatFrame.xml:141_OnEnterPressed"]:1: in function <[string "*ChatFrame.xml:141_OnEnterPressed"]:1>

@bloerwald
Copy link
Owner

also just a random note: filter quests seem to work (except for what I mentioned above), but for some reason unfiltering quests does not work.

Fix pushed, that was silly.

@JourneyOver
Copy link
Author

JourneyOver commented Sep 16, 2023

also just a random note: filter quests seem to work (except for what I mentioned above), but for some reason unfiltering quests does not work.

Fix pushed, that was silly.

Yep unfiltering quests works perfectly now. now it just seems that some how needs to find a way to hide quests that don't seem to have an ID attached to the quest icon in game.. as I made an edit in my above post:

edit: So it seems that if a quest icon does not have an ID attached to it, it does not allow the hiding of the icon at all, as I just did a test with another quest that doesn't seem to have an ID on the mouoseover tooltip for the quest and it did not hide that icon either. "https://www.wowhead.com/quest=76592/a-single-wing"

when I do input the quest ID in though like for example with the "A Single Wing" which does not have an ID in the tooltip and but would be /mc filterquest 76592 the line that comes up in the chat about it being filtered does show the correct name of the quest.

@bloerwald
Copy link
Owner

but mousing over the quest icon it sadly seems to not show an ID at all

Ugh, that's the worst. There are loads of different ways things show up on map. I guess, this is not a quest but something else.

Using

/dump (function() local kk={};for k,_ in pairs(WorldMapFrame.pinPools) do table.insert(kk,k)end return kk end)()

you can get a list of all current pins on the world map. Using

/script pp=(function() local kk={};for k,_ in pairs(WorldMapFrame.pinPools) do table.insert(kk,k)end return kk end)(); pit=pit or 1;print('removing',pp[pit]);WorldMapFrame:RemoveAllPinsByTemplate(pp[pit]);pit=pit+1

you can then remove a kind of pin one by one. Please keep doing so until the quest disappears and tell me what type of pin it was.

@JourneyOver
Copy link
Author

JourneyOver commented Sep 16, 2023

So the quest example I've been using "A Single Wing" seems to be related to the pin StorylineQuestPinTemplate, but it seems like none of the pins at all corrolate to the quest I actually want to hide "To Tame a Thunderspine" as I ran through all of them multiple times (/reloading before rerunning through them all again until I started getting nil value once again) and even testing by going to the specific map zone as well and doing it all over again)) and none of them seemed to remove the quest icon at all.

@bloerwald
Copy link
Owner

Storylines were my first assumption, those are (of course) different IDs.. Can you

/dump C_QuestLine.GetForceVisibleQuests(WorldMapFrame:GetID())
/dump C_QuestLine.GetAvailableQuestLines(WorldMapFrame:GetID())

please, to dump information on those?

@JourneyOver
Copy link
Author

JourneyOver commented Sep 16, 2023

Storylines were my first assumption, those are (of course) different IDs.. Can you

/dump C_QuestLine.GetForceVisibleQuests(WorldMapFrame:GetID())
/dump C_QuestLine.GetAvailableQuestLines(WorldMapFrame:GetID())

please, to dump information on those?

did both of those and both of them just comes up like:

[01:10:14 PM] Dump: value=C_QuestLine.GetForceVisibleQuests(WorldMapFrame:GetID())
[01:10:14 PM] [1]={
[01:10:14 PM] }
[01:10:27 PM] Dump: value=C_QuestLine.GetAvailableQuestLines(WorldMapFrame:GetID())
[01:10:27 PM] [1]={
[01:10:27 PM] }

Screenshot 2023-09-16 131211

test in both Valdarakken (where I am using my example quest) and in the Ohn'ahran Plains (where the quest is that I really want to hide)

another random note: The quest "To Tame A Thunderspine" is one of those kind of quests, where if you do it on one character it no longer is able to be done on alts, but idk if this is on blizzards part of how these quests just are or what is causing it to stay on the world map as I've never ran into a quest that behaved with the icon like this but the quest icon on at least the world map still ends up showing up on alts.

@bloerwald
Copy link
Owner

My bad, I forgot a "Map" in there.

/dump C_QuestLine.GetForceVisibleQuests(WorldMapFrame:GetMapID())
/dump C_QuestLine.GetAvailableQuestLines(WorldMapFrame:GetMapID())

@JourneyOver
Copy link
Author

Screenshot 2023-09-16 132038

so the first line didn't bring anything up again, but the second only brought up the example quest I've been using. I am in Ohn'ahran Plains at the moment while testing these in hopes of it catching the "To Tame A Thunderspine", though I don't think it matters where I am at in the world xD

@bloerwald
Copy link
Owner

Made myself an alt, got it to Maruuk renown 9, did the intro questline. I have no icon on the map at all. Is there another prerequisite?

@JourneyOver
Copy link
Author

Made myself an alt, got it to Maruuk renown 9, did the intro questline. I have no icon on the map at all. Is there another prerequisite?

To unlock the quests you'll need
Renown 9 with [Maruuk Centaur](https://www.wowhead.com/faction=2503/maruuk-centaur)
Level 70
Complete Initiate's Day out from [ Sojourner of Ohn'ahran Plains](https://www.wowhead.com/achievement=16405/sojourner-of-ohnahran-plains)

Initiate's Day out from [ Sojourner of Ohn'ahran Plains](https://www.wowhead.com/achievement=16405/sojourner-of-ohnahran-plains) starts from [Initiate Radiya](https://www.wowhead.com/npc=190014/initiate-radiya) at 56.12 77.01 in Ohn'iri Springs in Ohn'ahran Plains

Once unlocked the quests can be picked can be picked up from [Initiate Radiya](https://www.wowhead.com/npc=190014/initiate-radiya)
Once a quest is completed you'll have to wait for the daily reset to get the next quest in the chain.

In addition to the item asked for, all quests require 150 [ Dragon Isles Supplies](https://www.wowhead.com/currency=2003/dragon-isles-supplies) for each day Also. All items besides the Day 5 item can be sold and purchased on the Auction House.

Day 1 [ To Tame A Thunderspine](https://www.wowhead.com/quest=71196/to-tame-a-thunderspine) - Collect 20x [ Fluorescent Fluid](https://www.wowhead.com/item=192615/fluorescent-fluid) from any insect creature in the Dragon Isles. My spot /way 82.22 25.29
Day 2 [ To Tame A Thunderspine](https://www.wowhead.com/quest=71197/to-tame-a-thunderspine) - Deliver 20x [ High-Fiber Leaf](https://www.wowhead.com/item=192658/high-fiber-leaf). Drops from any plant creature. My spot /way 30.76 52.56
Day 3 [ To Tame A Thunderspine](https://www.wowhead.com/quest=71198/to-tame-a-thunderspine) - Deliver 10x [ Thousandbite Piranha](https://www.wowhead.com/item=194966/thousandbite-piranha). Can be fished anywhere in the Dragon Isles
Day 4 [ To Tame A Thunderspine](https://www.wowhead.com/quest=71199/to-tame-a-thunderspine) - Deliver 20x [ Woolly Mountain Pelt](https://www.wowhead.com/item=192636/woolly-mountain-pelt). Drops from woolly creatures in the Dragon Isles, like Mammoths and yaks. My spot /way 49.44 36.91
Day 5 [ To Tame A Thunderspine](https://www.wowhead.com/quest=71195/to-tame-a-thunderspine) - Deliver 1x [ Meluun's Green Curry](https://www.wowhead.com/item=200598/meluuns-green-curry). Purchased from [Ohn Meluun](https://www.wowhead.com/npc=190015/ohn-meluun) at /way 53.51 78.98

After completing all 5 quests, you'll be offered a final quest rewarding you with [ Lizi's Reins](https://www.wowhead.com/item=192799/lizis-reins)
You do NOT have to do the 5 quests in 5 days in a row. You can do 1, then wait however many days you want, and then do the next.

that's what is on wowhead (been so long I couldn't remember if there was or not)

@bloerwald
Copy link
Owner

Well, yes, I did that. I'll see whether it is there tomorrow or some weird thing.

@JourneyOver
Copy link
Author

JourneyOver commented Sep 16, 2023

Well, yes, I did that. I'll see whether it is there tomorrow or some weird thing.

(You have to do the whole zone on your alt as well till you get the achievement "Initiate's Day Out" part in "Sojourner of Ohn'ahran Plains" on the alt character as well and not just have the achievement done on another character as the main pre-requesit is the "Sneaking In" quest line)

but take your time, hopefully you can get things figured out soon enough ^^

@bloerwald
Copy link
Owner

bloerwald commented Sep 17, 2023

Just saw the quest requires level 70, so I guess that's the issue. I'm not sure I have the energy for that just to figure this out, I already did the main story line to give it another shot..

If you have an easier to reach alternative one, sure..

Also, as a last ditch effort, try /framestack and hovering the icon. Maybe in the stack there is some name giving it away.

@JourneyOver
Copy link
Author

If you have an easier to reach alternative one, sure..

So far this is the only quest that I have found that has been like this, I have yet to find any others.

Also, as a last ditch effort, try /framestack and hovering the icon. Maybe in the stack there is some name giving it away.

Tried this and there is sadly no info in the framestack that gives me the info to the quest icon.

@JourneyOver
Copy link
Author

Still haven't found any other quests that behaves like the "To Tame a Thunderspine" quest.

@Taizunz
Copy link
Contributor

Taizunz commented Jul 6, 2024

I'm experiencing a similar thing with a quest marker in Maldraxxus. It's part of a storyline, but it's also a weekly quest that reappears every week after you've done the storyline. The other quests in the storyline are not weekly quests.

https://www.wowhead.com/quest=57301/callous-concoctions
https://www.wowhead.com/storyline/mixing-monstrosities-1158

After adding 57301 to filterquest, hovering over the icon on the map no longer shows the ID of it.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants