-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing container tags #7
Comments
Do we not want to include latest to just be more verbose? I always side with explicit over implicit |
What branch do you build on? Cause I hardcoded it to look for the |
OH! I think it's because I'm using the version that's defined in the recipe yaml. I guess we would need to add logic to pull info from the base image to determine the proper fedora version huh? |
This seems to be tied to blue-build/github-action#2 |
Yeah, the info should be in
I think for new templates we want to lose the live/template branch structure, since the new reusable github action will handle all the updates in features. I'm not sure where you hardcoded this? |
Ok, I found the part where |
So with Gitlab CI, they have an env var to tell your pipeline what branch is the default branch. If I can find that var for Github, that would be a good replacement |
GitHub allows for environment variables. Go to settings, secrets/keys and it should be an environment option |
Forgot to respond to this
I was just thinking abt how startingpoint does things and keeping parity. Another argument is: latest should always mean latest version and date-latest might be contradicting. And of course the tags always pull the latest image with that tag, that's the point. :39 is the latest version of 39, so why wouldn't :20240101 be the latest version from that date? If one wants, they could specify a different version though, like :38-20240101. But the point of :latest is to roll over to the next version automatically, so I don't see the point of :date-latest. |
I was talking about the built in variables set by GitHub actions. I can look it up later |
From conversations in the Discord:
|
What should the the timestamp be formatted as? |
Same as now, YYYYMMDD. |
I just built & published my image with the tool and noticed there are some differences to startingpoint with the generated tags
version-date
andversion-commit
20240122
(startingpoint) vslatest-20240122
(bluebuild)The text was updated successfully, but these errors were encountered: