Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build.sh): export get_config_value and set_config_value to make ublue-update installer work #149

Closed
wants to merge 1 commit into from

Conversation

gerblesh
Copy link
Contributor

Dunno why the functions got deleted in the script, saw get_config_value was there, but wasn't exported, just fixed it up real quick. Noticed the issue when automatic updates with rpm-ostreed were still enabled when using the bling module to install ublue-update

…ke ublue-update installer work

Dunno why the functions got deleted in the script, saw get_config_value was there, but wasn't exported, just fixed it up real quick. Noticed the issue when automatic updates with rpm-ostreed were still enabled when using the bling module to install ublue-update
@gerblesh gerblesh requested a review from castrojo as a code owner September 12, 2023 06:52
@xynydev
Copy link
Member

xynydev commented Sep 12, 2023

I never created such functions, I just assumed this is something you added in while PRing in the ublue-update installer, apparently not.

No idea what these do, though. Some comments would be warranted.

Edit: Ok, so these are functions for changing values in .ini or .conf style files like rpm-ostreed.conf? I don't know if this is something we'd want to be in build.sh since it's not related to reading the configuration etc. I'd say these go better inside the module's code.

@gerblesh
Copy link
Contributor Author

originally the functions were included with the modules, I don't know how they got removed, i'll add them back in https://github.com/ublue-os/bling then

@gerblesh gerblesh closed this Sep 12, 2023
@gerblesh
Copy link
Contributor Author

reopening this to simply delete the set_config_value function inside build.sh

@gerblesh gerblesh reopened this Sep 12, 2023
@gerblesh
Copy link
Contributor Author

nvm it was never defined, all good

@gerblesh gerblesh closed this Sep 12, 2023
@gerblesh
Copy link
Contributor Author

New PR to fix this: blue-build/modules#37

@gerblesh gerblesh deleted the patch-1 branch October 20, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants