Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caching #4

Open
lukepighetti opened this issue Mar 30, 2022 · 4 comments
Open

caching #4

lukepighetti opened this issue Mar 30, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@lukepighetti
Copy link

Can caching be added to this? This is adding 1m 14s runs to our jobs.

@spydon
Copy link
Member

spydon commented Mar 31, 2022

Can caching be added to this? This is adding 1m 14s runs to our jobs.

Seems like it should be possible, do you want to give it a go and send a PR? https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows

We should probably have it behind an optional flag.

If you don't want to send a PR we'll pick it up when we get some time over to do it. :)

@lukepighetti
Copy link
Author

Any thoughts on how you'd like to see this implemented? (What exactly should be cached etc)?

@maxlapides
Copy link

I recommend implementing caching similar to how the flutter-action implements it:
https://github.com/subosito/flutter-action/blob/main/action.yml#L29-L33

@spydon
Copy link
Member

spydon commented Mar 31, 2022

Any thoughts on how you'd like to see this implemented? (What exactly should be cached etc)?

It's a bit tricky, since it is all the lock files and dependencies that should be cached, and not the full tree preferably.
Or maybe everything checked out should be cached after melos bootstrap has run, that would be the simplest...

@spydon spydon added the enhancement New feature or request label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants