List devices and battery levels in status icon tooltip #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
I may have unintentionally completely ignored this 😅 . It does need a rebase but in general this looks fine to me. |
Seems much more useful than the number.
...from ConnectionNotifier
|
Kudos, SonarCloud Quality Gate passed!
|
infirit
approved these changes
Aug 26, 2023
|
I'm not sure why but it seems like |
|
@cschramm , show the active profile, maybe? |
cschramm
added a commit
to cschramm/blueman
that referenced
this pull request
Apr 3, 2024
blueman-project#1911 introduced a bug. Fixes blueman-project#2321
cschramm
added a commit
to cschramm/blueman
that referenced
this pull request
Apr 3, 2024
blueman-project#1911 introduced a bug. Fixes blueman-project#2321
infirit
pushed a commit
to infirit/blueman
that referenced
this pull request
Apr 3, 2024
blueman-project#1911 introduced a bug. Fixes blueman-project#2321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
BatteryWatcher's users expect it to get destroyed and for thatBatteryWatcherexpect theManagerandBatteryobjects to get destroyed. The latter requires #1908 to actually happen and forManagerit does not work due to theself-references it passes to its signal handlers to be able to call itsemitmethod. I'm not sure if and how that could get resolved.Apart from that I'm not sure how good the idea of using that Unicode symbol actually is... 😅