Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvl-a50: mavlink2resthelper: fix incorrect IDs #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dvl-a50: mavlink2resthelper: fix incorrect IDs #31

wants to merge 2 commits into from

Conversation

ES-Alexander
Copy link
Contributor

@ES-Alexander ES-Alexander commented Aug 30, 2023 •
edited
Loading

  • system_id set to match the vehicle ID, since they should be part of the same system
  • component_id set to 197 (MAV_COMP_ID_VISUAL_INERTIAL_ODOMETRY)
    • ⚠️ if this field is meant to specify the intended recipient then it should be 1 instead, since it should be sent to the autopilot, but if that's the case I'm not sure how or where we're supposed to set the source ID

Fixes #30

Untested, so probably good if someone can try it before it gets merged.

@clydemcqueen
Copy link
Contributor

@ES-Alexander I will work on testing this in-water over the next few weeks.

@ES-Alexander
Copy link
Contributor Author

@clydemcqueen did you ever get around to testing this? :-)

@clydemcqueen
Copy link
Contributor

@ES-Alexander Sadly, we did not. I'll see if I can schedule some test time w/ a DVL-rigged ROV.

@clydemcqueen
Copy link
Contributor

@ES-Alexander -- sorry, testing this (and PR 34) is just not making it to the top of the queue. We have limited time to run these sorts of tests on real hardware, and the test process is cumbersome (creating a docker image per PR, installing them, etc.)

Are there plans to create BETA and DEV tracks for extensions? We always run the latest ArduSub BETA on production dives (to get surftrak and other nifty features). I think it would be straightforward to switch to the BETA track of this extension, if such a thing existed.

@clydemcqueen
Copy link
Contributor

I was prepping for a test dive later today, and I can't get this PR to run on my bench Pi running BlueOS. I'm getting errors like this:

2024-10-11 17:41:25.082 | WARNING  | dvl:load_settings:92 - Settings file not found, using default.
 * Serving Flask app "main" (lazy loading)
2024-10-11 17:41:25.087 | WARNING  | blueoshelper:request:13 - Error in request: http://127.0.0.1/cable-guy/v1.0/ethernet: <urlopen error [Errno 111] Connection refused>
2024-10-11 17:41:25.087 | DEBUG    | dvl:report_status:75 - waiting for cable-guy to come online...
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
 * Running on http://0.0.0.0:9001/ (Press CTRL+C to quit)
2024-10-11 17:41:26.090 | WARNING  | blueoshelper:request:13 - Error in request: http://127.0.0.1/cable-guy/v1.0/ethernet: <urlopen error [Errno 111] Connection refused>
2024-10-11 17:41:26.091 | DEBUG    | dvl:report_status:75 - waiting for cable-guy to come online...
2024-10-11 17:41:27.094 | WARNING  | blueoshelper:request:13 - Error in request: http://127.0.0.1/cable-guy/v1.0/ethernet: <urlopen error [Errno 111] Connection refused>
2024-10-11 17:41:27.095 | DEBUG    | dvl:report_status:75 - waiting for cable-guy to come online...
172.18.0.1 - - [11/Oct/2024 17:41:28] "GET / HTTP/1.1" 200 -
2024-10-11 17:41:28.098 | WARNING  | blueoshelper:request:13 - Error in request: http://127.0.0.1/cable-guy/v1.0/ethernet: <urlopen error [Errno 111] Connection refused>
2024-10-11 17:41:28.099 | DEBUG    | dvl:report_status:75 - waiting for cable-guy to come online...
172.18.0.1 - - [11/Oct/2024 17:41:28] "GET /register_service HTTP/1.1" 200 -
172.18.0.1 - - [11/Oct/2024 17:41:28] "GET /docs HTTP/1.1" 404 -
172.18.0.1 - - [11/Oct/2024 17:41:28] "GET /v1.0/ui/ HTTP/1.1" 404 -
2024-10-11 17:41:29.102 | WARNING  | blueoshelper:request:13 - Error in request: http://127.0.0.1/cable-guy/v1.0/ethernet: <urlopen error [Errno 111] Connection refused>
2024-10-11 17:41:29.103 | DEBUG    | dvl:report_status:75 - waiting for cable-guy to come online...
2024-10-11 17:41:30.106 | WARNING  | blueoshelper:request:13 - Error in request: http://127.0.0.1/cable-guy/v1.0/ethernet: <urlopen error [Errno 111] Connection refused>
...

Does this PR need to be rebased?

@clydemcqueen
Copy link
Contributor

Ping... any interest in this? We are doing some testing December 3-5 and could test this if you are interested.

@ES-Alexander
dvl-a50: mavlink2resthelper: fix incorrect IDs
1200a13 
- `system_id` set to match the vehicle ID, since they should be part of the same system
- `component_id` set to 197 (`MAV_COMP_ID_VISUAL_INERTIAL_ODOMETRY`)
@ES-Alexander
Copy link
Contributor Author

ES-Alexander commented Nov 27, 2024 •
edited
Loading

Does this PR need to be rebased?

I rebased and it doesn't seem to have that issue when I tried running it, so hopefully able to be tested now :-)

Ping... any interest in this?

Thanks for the ping. I think it's worth testing if it's not a hassle to do so, but given the lack of interaction with your original issue I don't expect this is a high priority for many people - mostly just a potential correctness thing, and a matter of convenience for log analysis.

@clydemcqueen
Copy link
Contributor

I don't expect this is a high priority for many people

Haha, clearly not. But thanks anyway! We have 3 days on the water next week (if the weather holds), so hopefully I am able to get some of these tests done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAVLink msgs have sysid=255, compid=0; should be sysid=1, compid=?
2 participants
@ES-Alexander @clydemcqueen