From b5f950b734f84f312b13ed1b200b43c30bb74d3a Mon Sep 17 00:00:00 2001 From: Matthew McGowan Date: Fri, 8 Sep 2023 02:36:35 -0700 Subject: [PATCH] fix: apparently cannot reference the `env` context. Remove the wait-for since the local tunnel check also tests connectivity to md5srv --- .github/workflows/notecard-binary-tests.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/notecard-binary-tests.yml b/.github/workflows/notecard-binary-tests.yml index 8099aed7..63526755 100644 --- a/.github/workflows/notecard-binary-tests.yml +++ b/.github/workflows/notecard-binary-tests.yml @@ -45,7 +45,7 @@ jobs: uses: actions/checkout@v3 - name: Generate ND5 Server Token run: | - [ -n "$MD5SRV_TOKEN" ] || echo "MD5SRV_TOKEN=abc" >> $GITHUB_ENV + [ -n "$MD5SRV_TOKEN" ] || echo "MD5SRV_TOKEN=`uuidgen`" >> $GITHUB_ENV - name: Check Env Vars run: | . scripts/check_runner_config.sh @@ -71,9 +71,6 @@ jobs: with: run: | bash ./scripts/runmd5srv.sh - wait-on: | - tcp:${{ env.MD5SRV_ADDRESS }}:${{ env.MD5SRV_PORT }} - wait-for: 1m # When done this way, the background process is terminated at the end of the step, # At least when running with `act`. The same may be true of github runners also.